You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tanstack/router-utils's test:unit script has been exit 0; vitest --typecheck since the package was created (#3287), so its tests never ran in CI. They already pass on main (2 files, 28 tests, no type errors), so this switches the script to vitest. Type checking stays on through typecheck: { enabled: true } in vite.config.ts.
This is split out of #8817, which makes the same script change.
Validated with nx run-many -p @tanstack/router-utils -t test:unit,test:types,test:eslint.
Updated the unit-test workflow to run the test suite directly. The command no longer performs an additional type-check step, so its execution is focused on unit tests. This change affects the project’s testing workflow only; no user-facing features or product behavior have changed.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This focused change re-enables the router-utils unit test command without introducing an actionable merge risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title "test(router-utils): re-enable unit tests" matches the main change. The PR changes the router-utils test:unit script from "exit 0; vitest --typecheck" to "vitest", so the unit tests run agai…
Description check
The description covers the change and its motivation. It explains that the test:unit script exited early with "exit 0", so tests never ran in CI. It reports that the tests already pass on main (2 file…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "test(router-utils): re-enable unit tests" matches the main change. The PR changes the router-utils test:unit script from "exit 0; vitest --typecheck" to "vitest", so the unit tests run again. The title is specific, short, and uses a conventional commit style.
Full details: Description check
Explanation
The description covers the change and its motivation. It explains that the test:unit script exited early with "exit 0", so tests never ran in CI. It reports that the tests already pass on main (2 files, 28 tests, no type errors). It states that type checking stays enabled through typecheck: { enabled: true } in vite.config.ts. It lists the validation command and links the related PR #8817. The description does not follow the repository template. It has no Checklist section and no Release Impact section, and it does not disclose AI authorship in the template's required form, even though it includes a Claude Code attribution line. The description is mostly complete, so the check passes, but the author should add the missing template sections.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between f723f3b and 71e07ab.
Files selected for processing: 1
packages/router-utils/package.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
⚠️1 benchmark with a significant change ran on different hardware
Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.
Main landed parts of this PR separately against the old compiler
(#8851, #8852, #8853, #8855, #8856) and re-enabled the router-utils unit
tests (#8849): the PR already has each of them. The old-compiler files
main edited stay deleted; the entries keep the PR's implementation (same
esbuild error message). Main's changesets stay; the duplicated bullets
leave the PR's router-plugin, route generator and compiler core
changesets. The router plugin skill takes main's esbuild wording.
#8857 (route-group layouts typed with full path '/'): the PR's generator
already types them '/'. Main's test that a childless `_auth.tsx` next to
the index route conflicts is dropped: SPEC J1.15 makes that pair valid
here (route-paths.test.ts checks it through the router).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ests the PR lacks
`test:unit` stays where main has it (#8849). Main's esbuild unit test
that the plugin refuses `autoCodeSplitting` duplicates the PR's J2.18
build test (integration/build-harness.test.ts); the splitter entry's
refusal and the generator-only entries have no other test and stay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tanstack/router-utils'stest:unitscript has beenexit 0; vitest --typechecksince the package was created (#3287), so its tests never ran in CI. They already pass onmain(2 files, 28 tests, no type errors), so this switches the script tovitest. Type checking stays on throughtypecheck: { enabled: true }invite.config.ts.This is split out of #8817, which makes the same script change.
Validated with
nx run-many -p @tanstack/router-utils -t test:unit,test:types,test:eslint.🤖 Generated with Claude Code
Summary by CodeRabbit