Repository navigation
fix(helm): render disabled default monitors so the agent keeps them off - #72
Merged
Merged
Conversation
When monitors.<x>.enabled was false the chart left that monitor out of the config, and the agent then added its built-in default for the type, enabled. So turning off cpu, memory, disk, ipForwarding or any IPv6 monitor in Helm did nothing. The chart now renders an entry with enabled: false, which stops the default from being added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monitors.<x>.enabled: falsein Helm did nothing for cpu, memory, disk, ipForwarding, ipv6Sysctl/Route/Neighbor/Firewall. The chart omitted the block, and the agent'sApplyDefaultMonitorsthen added the built-in default for that type, enabled. The chart now renders- name: <default name>, type: <type>, enabled: false, which the agent keeps.Checked end to end: rendered the chart with
monitors.cpu.enabled=falseandmonitors.ipv6Firewall.enabled=false, built the agent on Linux and ran-dump-config:cpu-healthipv6-firewall-checkhelm lintandhelm-verify-generatedpass. The gateway monitor has no chart values at all, so it still can't be turned off from Helm; left for a follow-up.🤖 Generated with Claude Code