Skip to content

fix(helm): render disabled default monitors so the agent keeps them off - #72

Merged
mattmattox merged 1 commit into
mainfrom
fix/helm-disabled-default-monitors
Oct 26, 2026
Merged

mattmattox merged 1 commit into
mainfrom
fix/helm-disabled-default-monitors

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

monitors.<x>.enabled: false in Helm did nothing for cpu, memory, disk, ipForwarding, ipv6Sysctl/Route/Neighbor/Firewall. The chart omitted the block, and the agent's ApplyDefaultMonitors then added the built-in default for that type, enabled. The chart now renders - name: <default name>, type: <type>, enabled: false, which the agent keeps.

Checked end to end: rendered the chart with monitors.cpu.enabled=false and monitors.ipv6Firewall.enabled=false, built the agent on Linux and ran -dump-config:

cpu-health ipv6-firewall-check
main chart enabled=true enabled=true
this PR enabled=false enabled=false

helm lint and helm-verify-generated pass. The gateway monitor has no chart values at all, so it still can't be turned off from Helm; left for a follow-up.

🤖 Generated with Claude Code

When monitors.<x>.enabled was false the chart left that monitor out of
the config, and the agent then added its built-in default for the type,
enabled. So turning off cpu, memory, disk, ipForwarding or any IPv6
monitor in Helm did nothing. The chart now renders an entry with
enabled: false, which stops the default from being added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit e18bc57 into main Oct 26, 2026
9 checks passed
@mattmattox
mattmattox deleted the fix/helm-disabled-default-monitors branch October 26, 2026 16:45
mattmattox added a commit that referenced this pull request Oct 26, 2026
…and #72 (#73)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant