Repository navigation
fix(remediation): read lease replies through the controller's envelope - #71
Merged
Merged
Conversation
The controller wraps every reply in {success, data, timestamp}, but the
agent's lease client decoded the body straight into LeaseResponse, so
approved was always false. With coordination on, every remediation was
refused even when the controller granted the lease, and the granted
lease stayed held until it expired.
The unit tests mocked an unwrapped reply, so they agreed with the bug.
They now send the real APIResponse shape, and two new tests run the
lease client against the real controller handler.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
remediation.coordination.enabled, every lease read as denied: the controller replies{success, data: LeaseResponse, timestamp}(writeSuccess), the agent decoded the body as a bareLeaseResponse, soapprovedwas the zero value. Remediation never ran under coordination, and the granted lease stayed held until expiry, blocking other nodes too.The mock in
lease_client_test.goreturned an unwrapped body, so the tests agreed with the bug. Mocks now usecontroller.APIResponse, andlease_client_controller_test.goruns the client against the real controller handler (grant, and deny overmaxConcurrentRemediations). Both new tests fail onmainand pass here;pkg/remediators,pkg/controller,cmd/...pass with-race.Only affects clusters running the controller with coordination on (no controller image is published today).
🤖 Generated with Claude Code