Repository navigation
fix: check ignored errors in journal, bitmap, refcount and more - #31
Merged
Merged
Conversation
…, trim, superblock Production fixes: - journal: a batched Commit returned nil even when the batch sync failed. Waiters now get the sync error, the timer path logs it, and Stop reports a failed final flush and leaves the journal dirty so the next mount replays it. - bitmap: a failed Alloc rollback leaked blocks silently; the returned error now names each block it could not free. - bitmap, refcount: a failed lock Release is logged. - node: a boot ID that fails to decode reads as unknown instead of half decoded; a slot that cannot be cleared after replay is logged. - storage, journal recovery: cleanup Close errors are discarded or logged. Tests check setup errors and discard cleanup errors explicitly. errcheck is now enforced in these packages and in internal/metrics and cmd/crctest; 303 findings remain elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 175 errcheck findings in
internal/{journal,bitmap,refcount,trim,superblock,storage,node,metrics}andcmd/crctest, and enforces errcheck there with apath-exceptrule.Behavior changes worth reviewing:
Commitreturned nil even when its batch sync failed. It now returns the sync error.Stopleaves the journal dirty if the final flush fails, so the next mount replays it.TestBatchCommitReturnsSyncErrorfails on main.Allocrollback leaked blocks without saying so. The error now names them.Releaseis logged rather than propagated, because it runs in a defer after the work has succeeded.Remaining errcheck: 303. tests/integration 61, snapshot 48, goclusterfs 46, dir 40, extent 26, lock 25, tests/benchmark 23, inode 14, fsck 8, sfb 3, cache 3, cache/broadcast 3, cmd/mount 2, cmd/fsck 1.
Tests on .68: unit tests with
-racepass, and the integration suite (-short) passes.🤖 Generated with Claude Code