Repository navigation
fix(journal): close the region in Stop when the final flush or MarkClean fails - #106
Merged
Merged
Conversation
…ean fails Stop returned early on those paths without calling region.Close. Close does nothing today, since the caller owns the device, so nothing leaked; Stop now always closes and joins the errors so a future Close cannot be skipped. A new test covers the failed-flush path of Stop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up from #31. When the final batch flush or
MarkCleanfailed,Stopreturned without callingregion.Close(). Now it always closes the region and joins the errors.No leak today:
Region.Closedoes nothing, because the device belongs to the caller. This change makes sure a futureClosecan't be skipped. No test can observe the close itself.Test:
TestStopReportsFailedBatchFlushcovers the failure path ofStop, which had no test before:Stop.Stopreturns nil.The test passes on main as well, because the behavior it checks didn't change.
🤖 Generated with Claude Code