Skip to content

fix(api): check ignored errors and enforce errcheck in internal/api - #117

Merged
mattmattox merged 2 commits into
mainfrom
claude/errcheck-api
Nov 13, 2026
Merged

mattmattox merged 2 commits into
mainfrom
claude/errcheck-api

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Fixes all 103 errcheck findings in internal/api (1 in production code, 102 in tests) and enforces errcheck there.

🤖 Generated with Claude Code

- writeJSON logs a failed response encode. The status line is already
  sent, so a marshal bug would otherwise leave a truncated 200 response
  with no trace.
- Tests stop servers through stopServer, which reports a failed Stop,
  and close response bodies through closeBody, which discards the error.
  TestServerStopStopsRateLimiter now asserts that stopping an unstarted
  server returns ErrServerNotStarted.

errcheck now covers internal/api.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deletes the internal/api errcheck rule and fixes the two findings in
#97's lifecycle_test.go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 89c131a into main Nov 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant