Skip to content

fix: check ignored errors in sfb and fileops; enforce errcheck there - #116

Merged
mattmattox merged 2 commits into
mainfrom
claude/errcheck-sfb-fileops-cache
Nov 13, 2026
Merged

mattmattox merged 2 commits into
mainfrom
claude/errcheck-sfb-fileops-cache

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

Fixes the errcheck findings in internal/sfb and internal/fileops and enforces errcheck there. It also fixes the cache and broadcast test findings.

🤖 Generated with Claude Code

- sfb logs container lock release failures as dir and inode do, and a
  container block it cannot free on rollback is now named in the error.
  SFB allocation is disabled, so this only matters for old images.
- fileops discards close errors explicitly: it opens only read-only
  descriptors and gets every result from Fstat or Fsetxattr first.
- Test setup in fileops and cache checks or discards errors explicitly.

errcheck now covers internal/sfb and internal/fileops. internal/cache
waits for cache/broadcast/transport.go, which #97 is editing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit fe5284a into main Nov 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant