Repository navigation
fix: check ignored errors in sfb and fileops; enforce errcheck there - #116
Merged
Merged
Conversation
- sfb logs container lock release failures as dir and inode do, and a container block it cannot free on rollback is now named in the error. SFB allocation is disabled, so this only matters for old images. - fileops discards close errors explicitly: it opens only read-only descriptors and gets every result from Fstat or Fsetxattr first. - Test setup in fileops and cache checks or discards errors explicitly. errcheck now covers internal/sfb and internal/fileops. internal/cache waits for cache/broadcast/transport.go, which #97 is editing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 13, 2026
…ileops-cache # Conflicts: # .golangci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the errcheck findings in
internal/sfbandinternal/fileopsand enforces errcheck there. It also fixes the cache and broadcast test findings.ErrNotLockOwner(a double release) as[ERROR], the same as in dir and inode. A block that rollback can't free is named in the returned error. SFB allocation has been disabled since fix: data-safety bugs in fallocate, block 0 reads, and SFB #12, so this only affects old images.O_PATHroot andO_RDONLYfiles), and results come fromFstatandFsetxattrbefore the close, so a close error carries nothing to act on.internal/cache. The rule matches by path prefix, so it would also covercache/broadcast/transport.go, which feat: clean API shutdown, /health states and shared CLI exit codes #97 is editing. I'll enforce cache after feat: clean API shutdown, /health states and shared CLI exit codes #97 merges.path-exceptline. I'll rebase whichever of my PRs lands later.🤖 Generated with Claude Code