Skip to content

Apply consolidated template-rule backlog (#36, #39–#51) - #54

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/template-rule-backlog-wave
Jun 14, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/template-rule-backlog-wave

Conversation

@dmccoystephenson

@dmccoystephenson dmccoystephenson commented Jun 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Bundles the 14 consolidated template-rule issues into create-dev-loop.md in one wave, the documented promotion pattern (CONVENTIONS §"Promoting a carry-over"; the May-25 wave bundled 8 the same way). Each fix is applied once to the template; the per-instance retrofit wave follows as one small PR per lagging skill.

Issue Phase Change
#36 header version/generated-at comments moved below the H1 so commands-format installs show the description, not the comment
#39 8 review-ready hand-off = valid terminal state; never --admin; explicit human auth satisfies a do-not-auto-merge hold
#40 4 / 1 self-review via plain PR comment (reviews API is blocked); backfill on carried-over PRs; inline comments stay in-hunk
#41 1 runtime working-tree resolution (env var → path → clean clone → fresh clone); new REPO_ENV_VAR placeholder
#42 5 / 1 autonomous multi-cycle batch mode + stop condition; externally-directed skip reason recorded once
#43 1 classify harness-blocked ops (CLAUDE.md edits, external submodule reg) at triage
#44 4 UNVERIFIED handling + scope-gated merge when the anchor can't run
#45 1 / 8 adopt a concurrent session's PR; harmless worktree --delete-branch failure
#46 4 green CI ≠ verification when CI scope excludes the changed files
#47 4 empirical Tests-fix (stash-and-run FAIL→PASS), not judged
#48 3 scope formatting to changed files
#49 3 scope ceiling counts non-test LOC; allow dependency-coupled batches
#50 6 don't hardcode the Co-Authored-By model; defer to the harness
#51 3 stage by name, never git add -A

Research grounding (per CLAUDE.md)

Validation

No automated suite (per CLAUDE.md). Structural validation on create-dev-loop.md: outer code fences balanced (13 pairs), escaped inner fences balanced (14 pairs), embedded template closes cleanly, new REPO_ENV_VAR placeholder has a Step-4 table row, no leftover formal-review API call or hardcoded model name. README + CLAUDE.md updated 1:1 for the #36 header move.

Closes #36, #39, #40, #41, #42, #43, #44, #45, #46, #47, #48, #49, #50, #51

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

Bundle the 14 consolidated template-rule fixes into the template in one wave
(per CONVENTIONS "Promoting a carry-over"):

- #36 move template-version/generated-at comments below the H1 heading so
  commands-format installs show the description, not the comment
- #39 review-ready hand-off is a valid Phase-8 terminal state; never --admin;
  explicit human authorization satisfies a do-not-auto-merge hold
- #40 self-review as a plain PR comment (not the blocked reviews API); backfill
  on carried-over PRs; keep inline comments inside the diff hunk
- #41 resolve the working tree at runtime (env var > path > clean clone > clone)
  instead of hardcoding an absolute path; add REPO_ENV_VAR placeholder
- #42 autonomous multi-cycle batch mode + stop condition; record
  externally-directed skip reasons once, not per-issue
- #43 classify harness-blocked ops (CLAUDE.md edits, external submodule reg)
  at triage; never drop a path CLAUDE.md still references
- #44 UNVERIFIED handling + scope-gated merge when the anchor cannot run
- #45 adopt a concurrent session's PR; harmless worktree --delete-branch failure
- #46 green CI is not verification when CI scope excludes the changed files
- #47 empirical Tests-fix (stash-and-run FAIL->PASS), not judged
- #48 scope formatting to changed files; don't pollute a focused PR
- #49 scope ceiling counts non-test LOC; allow dependency-coupled batches
- #50 don't hardcode the Co-Authored-By model; defer to the harness git rule
- #51 stage by name, never git add -A (leaks .claude/ harness state)

README and CLAUDE.md updated for the #36 header-position change.

Closes #36
Closes #39
Closes #40
Closes #41
Closes #42
Closes #43
Closes #44
Closes #45
Closes #46
Closes #47
Closes #48
Closes #49
Closes #50
Closes #51

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dmccoystephenson

dmccoystephenson commented Jun 14, 2026 •

Copy link
Copy Markdown
Member Author

Self-review rubric (anchor = structural validation; this repo has no CI suite, per CLAUDE.md):

Out-of-diff note (folded into body, not inline): the per-instance retrofit wave to the new baseline is the follow-up — one small PR per lagging skill, tracked separately.

One honest soft spot: #48's "scope formatting to changed files" is phrased against black/autoflake examples carried from the originating issue; per-instance retrofits should re-tune those to each repo's real formatter (or mark n/a where there is none).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit 335eef0 into main Jun 14, 2026
@dmccoystephenson
dmccoystephenson deleted the feature/template-rule-backlog-wave branch June 14, 2026 05:24
dmccoystephenson added a commit that referenced this pull request Jul 18, 2026
PR #54's own description states that #40, #44, #46, and #47 operationalize
findings §1, §2, and §5, but no Implementations entries were added under
those findings, leaving RESEARCH.md out of sync with CLAUDE.md's
"Implementations" convention.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
dmccoystephenson added a commit that referenced this pull request Aug 3, 2026
…ity, test comment (#103)

- README.md: use ln -sf for the Installation symlink, matching Step 5's
  own registration convention (create-dev-loop.md:624).
- CLAUDE.md: clarify that the ISSUE_TEMPLATE doc-table row's *.md glob
  deliberately excludes config.yml, which has no restatable conventions.
- tests/test_check_docs.py: note in the module docstring that any new
  test class must reset check_docs.errors in its own setUp(), so a
  future addition doesn't silently leak state between tests.

Not included, with reasons:
- RESEARCH.md's "Observed effect: pending — needs N cycles of data"
  entries (PRs #29/#30/#52/#54): this needs real usage data the
  maintainer would have to supply; nothing to mechanically edit here
  without fabricating an observed effect.
- The flagged openai.com RESEARCH.md link: re-verified via an
  independent fetch, still 403 (not 404) — consistent with bot/WAF
  blocking a non-browser client, not a confirmed dead link. Left as-is.
dmccoystephenson added a commit that referenced this pull request Aug 3, 2026
Bundle the 14 consolidated template-rule fixes into the template in one wave
(per CONVENTIONS "Promoting a carry-over"):

- #36 move template-version/generated-at comments below the H1 heading so
  commands-format installs show the description, not the comment
- #39 review-ready hand-off is a valid Phase-8 terminal state; never --admin;
  explicit human authorization satisfies a do-not-auto-merge hold
- #40 self-review as a plain PR comment (not the blocked reviews API); backfill
  on carried-over PRs; keep inline comments inside the diff hunk
- #41 resolve the working tree at runtime (env var > path > clean clone > clone)
  instead of hardcoding an absolute path; add REPO_ENV_VAR placeholder
- #42 autonomous multi-cycle batch mode + stop condition; record
  externally-directed skip reasons once, not per-issue
- #43 classify harness-blocked ops (CLAUDE.md edits, external submodule reg)
  at triage; never drop a path CLAUDE.md still references
- #44 UNVERIFIED handling + scope-gated merge when the anchor cannot run
- #45 adopt a concurrent session's PR; harmless worktree --delete-branch failure
- #46 green CI is not verification when CI scope excludes the changed files
- #47 empirical Tests-fix (stash-and-run FAIL->PASS), not judged
- #48 scope formatting to changed files; don't pollute a focused PR
- #49 scope ceiling counts non-test LOC; allow dependency-coupled batches
- #50 don't hardcode the Co-Authored-By model; defer to the harness git rule
- #51 stage by name, never git add -A (leaks .claude/ harness state)

README and CLAUDE.md updated for the #36 header-position change.

Closes #36
Closes #39
Closes #40
Closes #41
Closes #42
Closes #43
Closes #44
Closes #45
Closes #46
Closes #47
Closes #48
Closes #49
Closes #50
Closes #51

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dmccoystephenson added a commit that referenced this pull request Aug 3, 2026
PR #54's own description states that #40, #44, #46, and #47 operationalize
findings §1, §2, and §5, but no Implementations entries were added under
those findings, leaving RESEARCH.md out of sync with CLAUDE.md's
"Implementations" convention.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
dmccoystephenson added a commit that referenced this pull request Aug 3, 2026
…ity, test comment (#103)

- README.md: use ln -sf for the Installation symlink, matching Step 5's
  own registration convention (create-dev-loop.md:624).
- CLAUDE.md: clarify that the ISSUE_TEMPLATE doc-table row's *.md glob
  deliberately excludes config.yml, which has no restatable conventions.
- tests/test_check_docs.py: note in the module docstring that any new
  test class must reset check_docs.errors in its own setUp(), so a
  future addition doesn't silently leak state between tests.

Not included, with reasons:
- RESEARCH.md's "Observed effect: pending — needs N cycles of data"
  entries (PRs #29/#30/#52/#54): this needs real usage data the
  maintainer would have to supply; nothing to mechanically edit here
  without fabricating an observed effect.
- The flagged openai.com RESEARCH.md link: re-verified via an
  independent fetch, still 403 (not 404) — consistent with bot/WAF
  blocking a non-browser client, not a confirmed dead link. Left as-is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template-version HTML comment at file top breaks skill-list description for commands-format installs

1 participant