Skip to content

Phase 3: scope ceiling should count non-test LOC and allow dependency-coupled batches #49

Closed

Description

@dmccoystephenson

Template gap

Phase 3's soft scope ceiling (~400 net LOC / ~10 files) is regularly exceeded by legitimately coupled, well-tested batches. Example: a registration endpoint that requires its hashing service came to 428 LOC / 14 files, ~38% of it tests — splitting would have produced an unused-component PR. Every idiomatic endpoint ships DTOs, an exception + handler, a config class, and regression tests, each a small separate file, so test-heavy well-factored work hits the count fast without being "too large".

Rule to add to the template (Phase 3 scope ceiling)

Count the soft ceiling against non-test net LOC, and/or raise the soft threshold for dependency-coupled issues that cannot be split without leaving an unused component (keep the hard stop unchanged). Add: "If over the soft ceiling only because of (a) test code or (b) dependency-coupled issues that cannot be split, proceed but state the overage and the reason in the PR and self-review."

Consolidates (close on merge)

  • example-�-dev-loop#1 — soft scope ceiling exceeded by dependency-coupled, test-heavy batches

Consolidated upstream from per-loop self-audit findings. drafted by Claude on behalf of Daniel Stephenson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    template-ruleShould be promoted into create-dev-loop.md

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions