Repository navigation
Add check_local_links cases for fragments, relative resolution, and skips - #157
Merged
Merged
Conversation
…kips Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (this review was performed inline during a Gardener session, https://github.com/Stephenson-Software/gardener, because no independent reviewer was available):
Judgment notes:
Copilot could not be added as a reviewer ( drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckLocalLinksTestsintests/test_check_docs.py, which previously had three (resolvable link, broken link, external/anchor-only links ignored). This continues the Stage B unit-test expansion begun in Add check_placeholders cases for conditionals, section bounds, and trimming #155 and Add check_readme_steps_sync cases for section bounds, ordering, and matching rules #156 for the other two checks.#fragmentis stripped before the path is resolved (TARGET.md#sectionpasses)docs/UP.md→../TARGET.mdpasses;docs/SAME.md→TARGET.mdfails).mdfiles under.git/are skippedexists(), notis_file())image links are checked tooNo tracking issue: the coverage gap was found during triage. Every open issue was deferred this cycle because nearly all are
template-rulechanges tocreate-dev-loop.mdthat need a real/create-dev-loopvalidation run (see #109), and a headless dispatch cannot perform one. #106 editsCLAUDE.md, which is harness-blocked.Test plan
python3 -m unittest discover -s tests -v: Ran 32 tests, OK (up from 25)python3 scripts/check_docs.py: Doc consistency check passed.gitskip and fragment stripping were removed fromcheck_local_linksand doc-relative resolution was replaced with root-relative resolution. The three targeted new tests failed (test_docs_under_dot_git_are_skipped,test_fragment_is_stripped_before_resolving,test_link_resolves_relative_to_containing_doc). Production code was then restored, and all 32 tests passed./create-dev-looprun applies.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson