Repository navigation
Add check_readme_steps_sync cases for section bounds, ordering, and matching rules - #156
Merged
Merged
Conversation
…atching rules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Judgment call flagged: Do-not-auto-merge check: no protected path is matched. Only This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckReadmeStepsSyncTestsintests/test_check_docs.py, so thatcheck_readme_steps_syncgets the same edge-case coveragecheck_placeholdersreceived in Add check_placeholders cases for conditionals, section bounds, and trimming #155:##heading are not counted (section bound)## What it doessection at end of file is still read (the\Zbranch)[1, 1]vs[1])**lead are not counted### N -heading with a hyphen instead of an em dash is not counted as a Step. This also documents current behaviorNo tracking issue: the gap was found during triage (Stage B unit-test expansion).
Skipped backlog: every other open issue was deferred this cycle:
template-ruleissues and the other process issues (Phase 4's rubric scores the diff only, so PR-description obligations like CLAUDE.md's retrofit note go unchecked #120–Phase 5: compress the review wait for a single autonomous run with no reviewer assigned or requested #150) need changes to the template or its process text. Nothing can validate those changes in a headless dispatch ([self-audit] The repo's own validation anchor is structurally unrunnable in a headless dispatch, so template changes can never merge autonomously #109), so they could not merge autonomously.CLAUDE.mdedit. That is harness-blocked and needs separate operator authorization.Research grounding
RESEARCH.md §3: regression guards and characterization tests help an agent tell real fixes apart from coincidental patches. No template change is made.
Test plan
python3 scripts/check_docs.pyprinted "Doc consistency check passed."python3 -m unittest discover -s tests -vran 25 tests, all OK (19 before this change)/create-dev-looprun is needed because neithercreate-dev-loop.mdnor the template changed.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson