Repository navigation
Release: edge-apps-actions v26.10.2 (development → main) - #7
Open
salmanfarisvp wants to merge 9 commits into
Open
salmanfarisvp wants to merge 9 commits into
salmanfarisvp wants to merge 9 commits into
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Deploy stage on pushes to the default branch and production on vYY.M.PATCH tags, refusing tags not on the default branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks, Initialize and Update now call the reusable workflows; deploys queue instead of running side by side. Dependabot checks GitHub Actions weekly and targets development, so pin bumps go through the usual flow.
Use edge-apps-actions v26.10.2 and add release badge to README
chore: update icon path to consolidated icons directory
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical findings remain: the production initialization path lacks a main-branch guard, so it could run from unmerged code, and the update job does not pass an app ID for either target.
4 open issues
What changed in this PR
This release PR promotes development to main and moves the app's CI to the edge-apps-actions v26.10.2 reusable workflows. It also adds tag-based production releases and README release docs. Merging starts a stage deploy that waits for approval. A version tag on main then starts the production deploy.
Changes:
- CI workflows now call the reusable Checks, Initialize, and Update workflows at v26.10.2 instead of inline steps.
- Stage deploys run on
main. Production deploys run onvYY.MM.Ntags. - The manifest drops its
idand uses the consolidated icons path. The QC manifest is removed. - README gets a release badge and a tag-based release section.
| File | Description |
|---|---|
| screenly.yml | Removes the manifest id (single manifest for all environments) and updates the icon path. |
| screenly_qc.yml | Deleted, since one manifest now serves all environments. |
| README.md | Adds a release badge and documents the tag-based release steps. |
| .github/workflows/update-edge-app.yml | Replaces the stage and production jobs with one reusable update call. Adds tag triggers. Includes an unexpected master trigger. |
| .github/workflows/initialize-edge-app.yml | Switches to the reusable initialize workflow. The production branch guard was removed. |
| .github/dependabot.yml | Changes the update cadence and target branch. This is not mentioned in the PR description. |
Review effort: Lite
| edge_app_name: ${{ inputs.edge_app_name }} | ||
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| environment: ${{ inputs.environment }} | ||
| uses: Screenly/edge-apps-actions/.github/workflows/initialize.yml@v26.10.2 |
Comment on lines
+18
to
+22
| jobs: | ||
| update: | ||
| uses: Screenly/edge-apps-actions/.github/workflows/update.yml@v26.10.2 | ||
| secrets: | ||
| SCREENLY_API_TOKEN: ${{ secrets.SCREENLY_API_TOKEN }} |
Comment on lines
8
to
+9
| - main | ||
| - master |
Comment on lines
+18
to
+22
| jobs: | ||
| update: | ||
| uses: Screenly/edge-apps-actions/.github/workflows/update.yml@v26.10.2 | ||
| secrets: | ||
| SCREENLY_API_TOKEN: ${{ secrets.SCREENLY_API_TOKEN }} |
514sid
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttomain. This switches the app's CI to the edge-apps-actions v26.10.2 reusable workflows (Initialize Edge App, Update Edge App), and brings the README release docs. This repo has no Checks workflow, so this PR runs no CI.Changes since
mainAfter merging
main→ deploy to stage, which waits for approval in thestageenvironment.main(vYY.MM.N) and push the tag → deploy to production, which also waits for approval. Tags that aren't onmainare refused.