Repository navigation
chore: update icon path to consolidated icons directory - #2
Merged
Merged
Conversation
|
Heads up: this PR currently has merge conflicts with Flagged by an automated PR-hygiene sweep — no action needed beyond the rebase, and no reply expected. |
salmanfarisvp
marked this pull request as ready for review
October 29, 2026 15:23
salmanfarisvp
approved these changes
Oct 29, 2026
There was a problem hiding this comment.
🔵 Needs a closer look
The change deletes the entire QC manifest instead of updating only its icon URL, which would remove the app definition and break QC flows.
No open issues 🎉
What changed in this PR
Updates the iframe Edge App icon reference to the consolidated icons directory. The QC manifest is removed instead of being retained and updated, which can break QC flows that depend on it.
Changes:
- Updates the icon path in
screenly.yml. - Removes
screenly_qc.ymlrather than updating its icon path. - Critical review issue recorded for the deleted QC manifest (4 votes).
| File | Summary |
|---|---|
screenly.yml |
Icon reference updated to the consolidated icons directory. |
screenly_qc.yml |
Entire manifest removed; it should be retained with its icon reference updated. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconfield inscreenly.ymlandscreenly_qc.ymlto point to the new consolidated icons directory.Depends on Screenly/Playground#875.