Repository navigation
Release: edge-apps-actions v26.10.2 (development → main) - #7
Open
salmanfarisvp wants to merge 9 commits into
Open
salmanfarisvp wants to merge 9 commits into
salmanfarisvp wants to merge 9 commits into
Conversation
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Deploy stage on pushes to the default branch and production on vYY.M.PATCH tags, refusing tags not on the default branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks, Initialize and Update now call the reusable workflows; deploys queue instead of running side by side. Dependabot checks GitHub Actions weekly and targets development, so pin bumps go through the usual flow.
Use edge-apps-actions v26.10.2 and add release badge to README
chore: update icon path to consolidated icons directory
There was a problem hiding this comment.
🟡 Changes recommended
Two critical workflow calls no longer pass the environment-specific edge app ID, so initialization and deployment may target or create the wrong app; the README also contains a stale release-version example.
3 open issues
What changed in this PR
This PR promotes the Countdown Timer app to edge-apps-actions v26.10.2 reusable workflows, consolidates its manifest configuration, and documents the tag-based release process.
Changes:
- Replaces local deployment jobs with reusable Initialize and Update workflows.
- Removes the QC-specific manifest and updates the consolidated icon path.
- Adds release documentation, a badge, and preview image.
- Updates Dependabot to run weekly against
development.
This pull request requires changes.
| File | Changes | Review notes |
|---|---|---|
screenly.yml |
Removes the embedded app ID and updates the icon path. | No review comments. |
screenly_qc.yml |
Removes the environment-specific QC manifest. | No review comments. |
README.md |
Adds release metadata and tag-based release instructions. | Nit (2 votes): replace the stale v26.10.0 literal with the current version placeholder. Nit (1 vote): add --draft to the release command or update the preceding text. |
.github/workflows/update-edge-app.yml |
Migrates stage and production deployments to the v26.10.2 reusable workflow. | Critical (3 votes): forward the environment-specific app ID. Moderate (1 vote): add the promised Checks workflow caller or correct the release description. |
.github/workflows/initialize-edge-app.yml |
Migrates app initialization to the v26.10.2 reusable workflow. | Critical (3 votes): forward the required environment-specific app ID. |
.github/dependabot.yml |
Changes GitHub Actions updates to weekly and targets development. |
No review comments. |
Review effort: Lite
Comment on lines
+31
to
+37
| uses: Screenly/edge-apps-actions/.github/workflows/initialize.yml@v26.10.2 | ||
| with: | ||
| environment: ${{ inputs.environment }} | ||
| edge_app_name: ${{ inputs.edge_app_name }} | ||
| edge_app_title: ${{ inputs.edge_app_title }} | ||
| secrets: | ||
| SCREENLY_API_TOKEN: ${{ secrets.SCREENLY_API_TOKEN }} |
Comment on lines
+20
to
+22
| uses: Screenly/edge-apps-actions/.github/workflows/update.yml@v26.10.2 | ||
| secrets: | ||
| SCREENLY_API_TOKEN: ${{ secrets.SCREENLY_API_TOKEN }} |
| Then publish a GitHub Release whose notes list the pull requests merged since the previous release. Add `--draft` to review the notes before publishing: | ||
|
|
||
| ```bash | ||
| gh release create v26.10.0 --verify-tag --generate-notes --title v26.10.0 |
514sid
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttomain. This switches the app's CI to the edge-apps-actions v26.10.2 reusable workflows (Initialize Edge App, Update Edge App), and brings the README release docs. This repo has no Checks workflow, so this PR runs no CI.Changes since
mainAfter merging
main→ deploy to stage, which waits for approval in thestageenvironment.main(vYY.MM.N) and push the tag → deploy to production, which also waits for approval. Tags that aren't onmainare refused.