Skip to content

chore: update icon path to consolidated icons directory - #2

Merged
salmanfarisvp merged 2 commits into
developmentfrom
chore/update-icon-path
Oct 29, 2026
Merged

salmanfarisvp merged 2 commits into
developmentfrom
chore/update-icon-path

Conversation

@nicomiguelino

Copy link
Copy Markdown
Contributor
  • Updates icon field in screenly.yml and screenly_qc.yml to point to the new consolidated icons directory.

Depends on Screenly/Playground#875.

@nicomiguelino nicomiguelino self-assigned this Jun 30, 2026
@vpetersson-bot

Copy link
Copy Markdown

Heads up: this PR currently has merge conflicts with development and can't be merged as-is. A rebase (or merge from development) will clear it.

Flagged by an automated PR-hygiene sweep — no action needed beyond the rebase, and no reply expected.

@salmanfarisvp
salmanfarisvp marked this pull request as ready for review October 29, 2026 11:02
Copilot AI lite review requested due to automatic review settings October 29, 2026 11:02
@salmanfarisvp
salmanfarisvp merged commit 936f201 into development Oct 29, 2026
@salmanfarisvp
salmanfarisvp deleted the chore/update-icon-path branch October 29, 2026 11:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The critical issue remains unresolved because the change deletes screenly_qc.yml instead of preserving it and updating only its icon URL, potentially breaking QC/deployment flows.

No open issues 🎉

What changed in this PR

Updates the Countdown Timer app manifests to use the consolidated icons directory. However, screenly_qc.yml is deleted instead of having its icon field updated, leaving the stated change incomplete and potentially breaking QC or deployment flows that consume the manifest.

Changes:

  • Updates screenly.yml to reference edge-apps/icons/countdown-timer.svg.
  • Deletes screenly_qc.yml rather than retaining it with the updated icon path.
File Description
screenly.yml Updates the production manifest’s icon URL to the consolidated icons directory.
screenly_qc.yml Entire QC manifest is deleted; it should be retained with only its icon URL updated.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants