Repository navigation
chore: update icon path to consolidated icons directory - #2
Conversation
|
Heads up: this PR currently has merge conflicts with Flagged by an automated PR-hygiene sweep — no action needed beyond the rebase, and no reply expected. |
There was a problem hiding this comment.
🔵 Needs a closer look
The critical issue remains unresolved because the change deletes screenly_qc.yml instead of preserving it and updating only its icon URL, potentially breaking QC/deployment flows.
No open issues 🎉
What changed in this PR
Updates the Countdown Timer app manifests to use the consolidated icons directory. However, screenly_qc.yml is deleted instead of having its icon field updated, leaving the stated change incomplete and potentially breaking QC or deployment flows that consume the manifest.
Changes:
- Updates
screenly.ymlto referenceedge-apps/icons/countdown-timer.svg. - Deletes
screenly_qc.ymlrather than retaining it with the updated icon path.
| File | Description |
|---|---|
screenly.yml |
Updates the production manifest’s icon URL to the consolidated icons directory. |
screenly_qc.yml |
Entire QC manifest is deleted; it should be retained with only its icon URL updated. |
Review effort: Lite
iconfield inscreenly.ymlandscreenly_qc.ymlto point to the new consolidated icons directory.Depends on Screenly/Playground#875.