Repository navigation
fix(serve): hide incomplete GGUF shard sets from model list - #8
Merged
Vasyl-Trefilov merged 2 commits intoNov 6, 2026
Conversation
Signed-off-by: bettercallcaleb <121191527+bettercallcaleb@users.noreply.github.com>
Vasyl-Trefilov
self-requested a review
November 6, 2026 14:44
Member
|
Thanks for contribute, this is right. A model with a missing shard should not be offered, and summing shards across different |
Vasyl-Trefilov
pushed a commit
that referenced
this pull request
Nov 8, 2026
Vasyl-Trefilov
pushed a commit
that referenced
this pull request
Nov 8, 2026
Vasyl-Trefilov
pushed a commit
that referenced
this pull request
Nov 8, 2026
…in cache (#9) Closes #8. Arch/NVRTC bring-up for sm_70 (M1-T1): version detection, accurate 12.x guidance, a hard error for NVRTC >= 13 on pre-Ampere devices, Volta-marked startup line, and an NVRTC-tagged cubin cache key. A6 (version-scoped cache hit) stays deferred until M1-T2..M1-T6 make the sm_70 compile succeed.
Vasyl-Trefilov
pushed a commit
that referenced
this pull request
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The model list treats a split GGUF as loadable as soon as shard 1 exists, even if later shards are missing. It also sums shards with the same stem but different
-of-Ncounts. This can show a model that cannot load, with an incorrect size.Change
Require every numbered shard from 1 through the declared total, matching that exact total. Incomplete groups are omitted from the model list; regular single-file models remain unchanged.
Verification
cargo test --locked -- --skip spirv_is_fresh: passed.git diff --check: passed.spirv_is_freshfailure because the installed GLSL compiler rejects an existing shader; neither shaders nor SPIR-V were modified.