Skip to content

232 remove scipy requirement from core - #538

Merged
Nic-Ma merged 10 commits into
Project-MONAI:masterfrom
wyli:232-remove-scipy-from-core
Jun 12, 2020
Merged

Nic-Ma merged 10 commits into
Project-MONAI:masterfrom
wyli:232-remove-scipy-from-core

Conversation

@wyli

@wyli wyli commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

part of #232

Description

removes scipy from the requirement list
adds scipy to requirements-dev.txt, as it's used as unit test references

Status

Hold (please merge #532 first)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@wyli
wyli requested a review from Nic-Ma June 11, 2020 17:10
@wyli
wyli force-pushed the 232-remove-scipy-from-core branch from c27e5cb to 675edb1 Compare June 11, 2020 18:27

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

@Nic-Ma
Nic-Ma merged commit a1a5d6d into Project-MONAI:master Jun 12, 2020
@wyli
wyli deleted the 232-remove-scipy-from-core branch October 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants