Repository navigation
232 remove scipy requirement from core - #538
Merged
Merged
Conversation
wyli
force-pushed
the
232-remove-scipy-from-core
branch
from
June 11, 2020 18:27
c27e5cb to
675edb1
Compare
Nic-Ma
approved these changes
Jun 12, 2020
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #232
Description
removes scipy from the requirement list
adds scipy to requirements-dev.txt, as it's used as unit test references
Status
Hold (please merge #532 first)
Types of changes