Skip to content

Remove required dependency on scikit-image and scipy #232

Closed

Description

@tvercaut

scikit-image and scipy are currently required dependencies of MONAI. However, it looks like these are used to implement a small number of features that can be implemented with PyTorch.

Limiting the number of required dependencies is good practice and for the particular case at end, replacing these implementations by PyTorch ones may help towards fixing #189

See https://github.com/kornia/kornia/blob/master/kornia/geometry/transform/imgwarp.py#L126 foe examples of replacing skimage.transform.resize and scipy.ndimage.zoom with PyTorch based code based on affine_grid and grid_sample. There is related discussion in #112

Activity

  1. changed the title [-]Remove dependency on scikit-image and scipy[/-] [+]Remove required dependency on scikit-image and scipy[/+] on Mar 30, 2020
  2. tvercaut commented on Apr 29, 2020

    @tvercaut
    MemberAuthor

    This is also linked to #290 where a related issue is highlighted but with cupy

  3. wyli commented on Jun 29, 2020

    @wyli
    Contributor

    this is mostly done -- scipy removed, scikit-image becomes an optional for the connected component analysis I'm closing this in favour of #554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions