You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Optional dependency cupy is not tested normally #290
Describe the bug
The cupy library is used to do zooming on GPU as an optional requirement, if not installed scipy is used. The requirements.txt doesn't mention it so the test setup doesn't install it, leading to a number of test cases to do nothing rather than test the functionality.
One bug that is present is the test_gpu_zoom test in tests/test_rand_zoomd.py where line 63 should be:
@wyli This is actually not fixed. The test is fixed, but the test only runs if cupy is installed. Currently, cupy is not installed on the CI machines, and @tvercaut suggests that it should not be used or depended upon. I would recommend re-opening this issue until a solution regarding the use of cupy is agreed upon.
Activity
tvercaut commentedon Apr 29, 2020
As discussed in the weekly meetings, we should whenever feasible, favour pure pytorch implementations. Relying on cupy for such a function doesn't sound like it's worth it. See e.g. how rising does it (although taking care of aliasing issues is probably also needed if dezooming is being performed):
https://github.com/PhoenixDL/rising/blob/874b9b83fb1a9bd3791e273d187a163cf100fc1c/rising/transforms/spatial.py#L144-L180
hjmjohnson commentedon May 29, 2020
@wyli This is actually not fixed. The test is fixed, but the test only runs if cupy is installed. Currently, cupy is not installed on the CI machines, and @tvercaut suggests that it should not be used or depended upon. I would recommend re-opening this issue until a solution regarding the use of cupy is agreed upon.