Skip to content

232 revise nifti writer - #502

Merged
wyli merged 10 commits into
Project-MONAI:masterfrom
wyli:232-revise-nifti-writer
Jun 10, 2020
Merged

wyli merged 10 commits into
Project-MONAI:masterfrom
wyli:232-revise-nifti-writer

Conversation

@wyli

@wyli wyli commented Jun 6, 2020 •

Copy link
Copy Markdown
Contributor

subtask of #232

revise niftiwriter to use affine transform instead of scipy.ndimage.affine_transform

Status

WIP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docstrings/Documentation updated

Comment thread monai/data/nifti_saver.py Resolved
Comment thread monai/data/nifti_writer.py Resolved
@wyli
wyli force-pushed the 232-revise-nifti-writer branch 2 times, most recently from 937aadb to b5f45da Compare June 8, 2020 12:37
@wyli

wyli commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

thanks @Nic-Ma, I incorporated your comments and double-checked the relevant unit tests.

@wyli
wyli force-pushed the 232-revise-nifti-writer branch 2 times, most recently from 2160f00 to be0728f Compare June 8, 2020 16:34
@wyli wyli mentioned this pull request Jun 9, 2020
3 tasks done
Comment thread monai/data/nifti_saver.py Resolved
Comment thread monai/handlers/segmentation_saver.py Resolved
@hjmjohnson

Copy link
Copy Markdown
Contributor

@wyli This is an evolutionary step forward at a minimum. I recommend including this and #511 so that they this changes for the basis for another incremental improvement.

@wyli
wyli force-pushed the 232-revise-nifti-writer branch from ff3f02a to c723a74 Compare June 9, 2020 13:32
@wyli
wyli force-pushed the 232-revise-nifti-writer branch from 3c9e21d to a6c3833 Compare June 10, 2020 12:15
@wyli
wyli merged commit 1cfea05 into Project-MONAI:master Jun 10, 2020
@wyli
wyli deleted the 232-revise-nifti-writer branch October 6, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants