This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Repository navigation
Fix/production builds - #45
Merged
Merged
Conversation
This is required to avoid runtime errors on production. NODE_ENV is still 'production' in runtime, this is only a build-time change
RafaelVidaurre
force-pushed
the
fix/production-builds
branch
from
September 28, 2018 00:25
dc9da05 to
19f24a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After struggling with this, it turned out
NODE_ENVandBABEL_ENVset as "production" on build time were creating invalid builds for some reason.This is probably not ideal, but for now we'll have to roll with this.
I also updated some dependencies that were throwing warnings, this is not super-related but since its done and everything works I thought I'd leave it in this PR too.