Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

Revisit production builds #46

Open

Description

@RafaelVidaurre

A sort of hacky fix (Setting NODE_ENV to development on build time) had to be put in place to allow production builds to work. This was merged in #45

This issue is for taking the time to look into this as a team and figure out how to deal properly with this issue.

Activity

  1. Grsmto commented on Sep 28, 2018

    @Grsmto
    Contributor

    Would be a good idea to check at CRA as they are releasing v2 with Webpack4 + Babel7 support so our solution is probably there. Also they are dropping support for monorepo (bit scary for us) but I'm not sure what this means but worth having a look:
    https://gist.github.com/gaearon/8650d1c70e436e5eff01f396dffc4114#monorepo-support-from-2x-alphas-was-removed-in-final-20

  2. RafaelVidaurre commented on Oct 1, 2018

    @RafaelVidaurre
    ContributorAuthor

    Definitely worth looking at!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GithubFor Asana integration use onlyenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions