[ramonsmits]

Partially addresses:

• Warn operators before an index definition change triggers a RavenDB index rebuild #6015

IndexDeployment now logs what it decides at start-up:

• one line per database with its static index search engine setting, or that none is set
• one line per index with the engine it uses and whether the engine is set on the index or inherited from the database
• a warning for each index that RavenDB rebuilds because its definition changed, with the differences that cause the rebuild
• a warning for a locked index, because definition changes from new versions are not applied to it
• an error for a locked index whose definition changed, because the change is not applied until the operator unlocks the index

Not included, left for #6015: the number of documents the rebuild covers, a setting that refuses a rebuild at start-up, and the same information in ServiceControl Management before the upgrade.

[mauroservienti]

As is, this message could raise support questions for no good reason. What about:

Suggested change

	Logger.LogWarning("Index {IndexName} is locked ({LockMode}). Definition changes from new versions are not applied until the index is unlocked", index.IndexName, existing.LockMode);
	Logger.LogWarning("Index {IndexName} is locked ({LockMode}). This version of ServiceControl doesn't contain index changes. Definition changes from new versions are not applied until the index is unlocked", index.IndexName, existing.LockMode);

[ramonsmits]

Agreed, however, I would try to make it shorter...

Something like "Index XX is locked but definition is full compatible"?

[ramonsmits]

@mauroservienti and I have discussed that maybe it is even better to throw an exception here as some part of application depends on this change. If this part is not critical then maybe its not that important to throw but we align on that we should throw here.