Repository navigation
Stop adding the Corax search engine setting to existing databases - #6034
Open
ramonsmits wants to merge 1 commit into
Open
ramonsmits wants to merge 1 commit into
ramonsmits wants to merge 1 commit into
Conversation
ramonsmits
added this pull request to stack #6037
October 20, 2026 15:00
ramonsmits
force-pushed
the
search-engine-database-setting
branch
from
October 20, 2026 15:02
55dd1fa to
1ab5c36
Compare
mauroservienti
approved these changes
Oct 20, 2026
ramonsmits
marked this pull request as ready for review
October 21, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateDatabaseSettingsaddedIndexing.Auto.SearchEngineTypeandIndexing.Static.SearchEngineTypewith value Corax to every database that had no such settings, at every start-up, including a start in maintenance mode. The intent was a one-time pin for databases created before 6.20. The code cannot tell "never pinned" from "the operator removed the setting", so it also undid an operator's choice.RavenDB Studio removes a database setting whose value equals the server default. An operator who sets both keys to Lucene on a server whose default is Lucene therefore deletes the keys, and ServiceControl restored Corax at the next start. The "Migrating the whole database" procedure in the documentation produced exactly this.
The pin had no benefit. RavenDB stores the engine in each index and reads it back when the database opens, so a database default does not rebuild existing indexes. The default is used only for a new index, a reset, or a side-by-side replacement after a definition change.
DatabaseSetupclasses no longer write the Corax settings. New databases are still created with Lucene.DatabaseSettingsTestsdeletes the settings, reloads the database, runs the setup and asserts the settings stay absent.Existing settings written by 6.20.0 to 6.21.2 are not removed; the next PR in the stack makes the engine of rebuilt indexes independent of them.