Repository navigation
#246 - Break Apart routes Module Into Package - Try 2 - #267
Merged
Digbigpig merged 9 commits intoDec 26, 2019
Merged
Conversation
I had to extract some shared stuff into other modules in order to support doing this.
The linter is complaining about unused imports, but importing them here actually causes side effects that Flask relies on to have the web service properly configured.
Contributor
Author
|
Added #noqa line to try and resolve flake8 error, but no joy. @aaron-suarez; can you take a look? I have no clue why Flake is ignoring that comment. |
aaron-junot
reviewed
Dec 26, 2019
aaron-junot
reviewed
Dec 26, 2019
Renames _unauthorized_response to unauthorized_response Exempts __init__.py from test coverage.
Member
|
This also fixes #246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a retry on #247, hopefully properly taking into account the current state of master. I tried rebasing #247, but it was too big of a deal to accomplish.