Skip to content

#246 - Break Apart routes Module Into Package - #247

Closed
Jitsusama wants to merge 10 commits into
OperationCode:masterfrom
Jitsusama:246-routes-module-split
Closed

Jitsusama wants to merge 10 commits into
OperationCode:masterfrom
Jitsusama:246-routes-module-split

Conversation

@Jitsusama

@Jitsusama Jitsusama commented Oct 26, 2019 •

Copy link
Copy Markdown
Contributor

This PR, as per the request in #246, breaks apart the routes module into a new package, where separate modules organized by functional area.

@Jitsusama

Copy link
Copy Markdown
Contributor Author

I just noticed there are conflicts, I guess my master branch was too old. That's a bummer.

@aaron-junot

Copy link
Copy Markdown
Member

Yeah, and speaking of that, this is going to cause conflicts with probably every open PR that there is. We should probably consider a rollout strategy for this. Or at least wait to merge it until all of the currently open PRs are merged (though I don't want to block you indefinitely on the batch create one, I'll rebase that if I have to). I just don't want to break everyone else's WIP stuff

@aaron-junot
aaron-junot self-requested a review October 26, 2019 23:23
@Jitsusama

Copy link
Copy Markdown
Contributor Author

What do you recommend? Should I start from scratch off of current master, or not? For selfish reasons, I'd like to get this brought in before Hacktoberfest is over.

@Jitsusama Jitsusama changed the title 246 - Break Apart routes Module Into Package #246 - Break Apart routes Module Into Package Oct 26, 2019
@aaron-junot

Copy link
Copy Markdown
Member

The rules of Hacktoberfest say that you need to open 4 PRs, not that those PRs need to be merged. If we need to let this sit into November that's fine. I wouldn't recommend opening the PR to break up the test_routes.py just yet, but you can open two other PRs to get them in for Hacktoberfest even while this one remains unmerged.

If you need help deciding what else to open up, hit me up on slack, I have a couple ideas.

@C-Lion

C-Lion commented Oct 26, 2019

Copy link
Copy Markdown

You can also just submit a PR called Issue #XXX WIP. As long as the repo manager doesn't reject it or mark it as spam it should count as valid for Hactoberfest.

@Jitsusama

Copy link
Copy Markdown
Contributor Author

Thanks @C-Lion; I'll just rebase when things settle down a bit.

@Jitsusama

Copy link
Copy Markdown
Contributor Author

Retrying in #267.

@Jitsusama Jitsusama closed this Dec 25, 2019
@aaron-junot

Copy link
Copy Markdown
Member

This also closes #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants