Skip to content

Add pathfinder support for cupti64_2026.1.2.dll (CTK 13.2.2) - #3279

Merged
rwgk merged 3 commits into
NVIDIA:mainfrom
zklaus:cupti-2026.1.2
Oct 29, 2026
Merged

rwgk merged 3 commits into
NVIDIA:mainfrom
zklaus:cupti-2026.1.2

Conversation

@zklaus

@zklaus zklaus commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Description

nvidia-cuda-cupti 13.2.86 (CUDA 13.2.2) ships cupti64_2026.1.2.dll on Windows, which the cupti descriptor does not list, so load_nvidia_dynamic_lib("cupti") fails on a machine that only has the 13.2 wheels installed.

Found via the PyTorch cu132 Windows nightly, which loads the CUDA wheel libraries through cuda-pathfinder at import time (pytorch/pytorch#202206).

Checklist

  • I have read the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

nvidia-cuda-cupti 13.2.86 (CUDA 13.2.2) ships cupti64_2026.1.2.dll on
Windows, which the cupti descriptor does not list, so
load_nvidia_dynamic_lib("cupti") fails on a machine that only has the
13.2 wheels installed.

Found via the PyTorch cu132 Windows nightly, which loads the CUDA wheel
libraries through cuda-pathfinder at import time
(pytorch/pytorch#202206).

Signed-off-by: Klaus Zimmermann <klaus.zimmermann@quansight.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the cuda.pathfinder Everything related to the cuda.pathfinder module label Oct 29, 2026
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 916198a and ed8b385.

Files selected for processing: 2
  • cuda_pathfinder/docs/nv-versions.json
  • cuda_pathfinder/docs/source/release/1.8.5-notes.rst

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows compatibility for applications using CUDA profiling tools. The library lookup now recognizes cupti64_2026.1.2.dll among the preferred versions, helping applications locate the matching library when needed.
  • Documentation
    • Added release notes and a documentation listing for version 1.8.5, including details about support for this Windows CUPTI library.

The Windows CUPTI DLL preference list now includes cupti64_2026.1.2.dll. The documentation adds CUDA PathFinder version 1.8.5 and release notes for this DLL.

Changes: CUPTI DLL candidates

Layer / File(s) Summary
Windows DLL candidate list
cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py, cuda_pathfinder/docs/nv-versions.json, cuda_pathfinder/docs/source/release/1.8.5-notes.rst
The CUPTI Windows DLL preference list adds cupti64_2026.1.2.dll between the 2026.2.0 and 2026.1.1 entries. The version list adds 1.8.5, and the release notes describe the DLL addition.

Possibly related issues

Possibly related PRs

  • NVIDIA/cuda-python#3233: Adds lookup APIs that use the descriptor catalog, which now includes the new DLL candidate.

Suggested labels: enhancement

Suggested reviewers: rwgk

Priority: Normal

Change: Feature

Merge Risk: Minimal · up to ed8b3

No actionable merge risk remains.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

"cupti64_2026.3.0.dll",
"cupti64_2026.2.1.dll",
"cupti64_2026.2.0.dll",
"cupti64_2026.1.2.dll",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add cupti discovery unit tests to the prei-existing set. Thank you.

@rwgk rwgk Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have that, but this particular version escaped our testing:
In theory, we'd have to test against all released CTK version, every major.minor release.
Currently we're only testing against the latest major.minor releases.

It's a complex project to ensure full coverage at a reasonable cost (runner time).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue will be fixed with the next CTK release onwards. Windows Cupti will follow the same naming convention as linux

"cupti64_2026.3.0.dll",
"cupti64_2026.2.1.dll",
"cupti64_2026.2.0.dll",
"cupti64_2026.1.2.dll",

@rwgk rwgk Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have that, but this particular version escaped our testing:
In theory, we'd have to test against all released CTK version, every major.minor release.
Currently we're only testing against the latest major.minor releases.

It's a complex project to ensure full coverage at a reasonable cost (runner time).

@rwgk rwgk added this to the cuda.pathfinder next milestone Oct 29, 2026
@rwgk rwgk added the P0 High priority - Must do! label Oct 29, 2026
@leofang leofang linked an issue Oct 29, 2026 that may be closed by this pull request
1 task done
zklaus and others added 2 commits October 29, 2026 16:51
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
@rwgk

rwgk commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

I just pushed pathfinder 1.8.5 release notes, so that we can make a pathfinder release immediately after this PR merges.

@rwgk

rwgk commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

/ok to test ed8b385

@rwgk
rwgk enabled auto-merge (squash) October 29, 2026 16:05
@rwgk

rwgk commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

I set this PR to auto-merge. I'll keep an eye on it and will start the release after the PR has merged. End-to-end it'll probably take 3-4 hours to get the release out (2 x full CI is the bottleneck).

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

@rwgk
rwgk merged commit ecaba92 into NVIDIA:main Oct 29, 2026
216 of 219 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 29, 2026
Removed preview folders for the following PRs:
- PR #2494
- PR #3186
- PR #3259
- PR #3274
- PR #3275
- PR #3279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Windows CTK 13.2.2 CUPTI Name Unsupported

4 participants