Repository navigation
ci(release): promote qualified prereleases to stable - #4611
Merged
Merged
Conversation
SDAChess
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 15, 2026 17:01
|
🌿 Preview your docs: https://nvidia-preview-pr-4611.docs.buildwithfern.com/openshell |
matthewgrossman
left a comment
Member
There was a problem hiding this comment.
Nice design overall. The evidence check is strict, existing stable tags never move, the build re-checks the source commit, and successful reruns keep earlier evidence. Together these make a mis-tag hard. Thanks for also picking up the two follow-ups from #4420. Inline comments cover the npm bug and the rebuild tradeoff; two notes here are about lines outside the diff:
- Shared image tag.
release-build.ymlstill pushes stable images togateway|sandbox|supervisor:<source_sha>. That is the same tag the qualified prerelease used and that qualification scanned and tested. After promotion,:<sha>points to the stable rebuild, not the evaluated image. The:X.Y.Z-pre.Ntags still point to the qualified images, so nothing breaks. Anyone following the evidence by commit, or rerunning integration withsource-sha, gets different bits. If a Pre-release or Release Dev run for the same commit overlapped,:X.Y.Zcould even be created from a prerelease image. That risk predates this PR. Low priority, but a distinct tag for the stable build, such as<sha>-stable, would avoid it. - Live run. Nothing was dispatched for this or #4420. A throwaway-tag run on a fork before the first real promotion would cover tag creation with the workflow token, the artifact zip download, and cross-workflow permissions.
SDAChess
force-pushed
the
ci/release-orchestration/SDAChess
branch
from
October 15, 2026 17:34
a6f708f to
52a42e4
Compare
7 tasks done
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
force-pushed
the
ci/4609-promote-qualified-prereleases/SDAChess
branch
from
October 19, 2026 09:53
c742c23 to
c55431a
Compare
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
alangou
previously approved these changes
Oct 19, 2026
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
enabled auto-merge
October 19, 2026 10:24
alangou
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatch Release from the intended branch with a stable version to select its latest passing prerelease, verify its recorded qualification evidence, and create the stable tag at that exact commit. Rebuild and publish stable artifacts without repeating qualification, while keeping support releases from replacing newer shared latest channels.
Related Issue
Closes #4609.
Builds on #4420, which is merged. Related: #3559 and #3632. Artifacts are rebuilt because their versions are compiled in.
Changes
latest; preserve the prerelease's commit-SHA images.uv/npmcommands, without the CI image or mise.latest, GitHub's latest release, npmlatest, and snaplatest/stablefor older support versions. Support npm packages userelease-X.Y; snap files stay in GitHub Releases. Docs already prevent latest from moving backward.Testing
git diff --checkpass. Exclude only Actionlint's unsupportedqueue: maxdiagnostic; the existing branch-docs credential-persistence warning remains unchanged.latestandrelease-0.4.Checklist