Repository navigation
ci(release): decouple prerelease publication from qualification - #4420
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-4420.docs.buildwithfern.com/openshell |
f05c4ed to
4b9eeb9
Compare
ab9dea1 to
72da79a
Compare
4b9eeb9 to
e8d4b29
Compare
72da79a to
b5c6491
Compare
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. cli — No explicit risk acceptance found
Review details
Advisory review; publication gates are unchanged. |
This is okay, we actually defined that in RFC0014 |
|
Label |
matthewgrossman
left a comment
There was a problem hiding this comment.
Nice split overall. The shared build and publish workflows make the two release orders easy to follow, and the early tag-type check in release-build.yml is a good guard. My comments are inline, plus two things outside the diff:
- Stale references to the old workflow.
.agents/skills/watch-github-actions/SKILL.md:128still says "Release Tagtemporarily omits Codex Security".scripts/baseline_workflow_metrics.py:55tracksrelease-tag.ymlbut notrelease-prerelease.yml. Since nightlies now run under Pre-release, almost all release runs will disappear from the metrics. Persync-agent-infra, these should be updated in this branch. - Live test. The description says no release workflow was dispatched. A test Pre-release dispatch on a throwaway tag before merge would exercise the new permissions between the calling and called workflows and the
actions: readartifact downloads inrelease-publish.yml.
|
Pushed a6f708f with the agreed tag-trigger support, parallel prerelease publication/qualification, and best-effort OCI summary publication. Replied on each inline thread with the changes and the intentional installer behavior. Validation: Actionlint, qualification-summary tests, release dependency checks, docs navigation, and git diff --check pass. Live publication and qualification will be checked using a real prerelease after merge; no throwaway tag or release workflow was dispatched for this review. The two infrastructure follow-ups from the review overview remain open: the older |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. cli — Risk explicitly accepted
Review details
Advisory review; publication gates are unchanged. |
matthewgrossman
left a comment
There was a problem hiding this comment.
lgtm: thanks for the quick turnaround. Follow-ups (fine in a separate PR):
.agents/skills/watch-github-actions/SKILL.md:128still says "Release Tagtemporarily omits Codex Security…"; it should name Release and Pre-release.- Add
release-prerelease.ymltoWORKFLOWSinscripts/baseline_workflow_metrics.py, otherwise nightly runs drop out of the metrics. - Start qualification without waiting for the snap and wheel builds, as discussed.
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
a6f708f to
52a42e4
Compare
Summary
Publish pre-release artifacts independently of qualification so a flaky qualification run cannot prevent candidate availability and a publication failure cannot skip qualification. The same Pre-release run calls qualification, fails when a required suite fails, and sends the existing failure notification while published artifacts remain available.
Stacked on #4419; merge the qualification extraction first, then retarget this PR to
main.Related Issue
Direct maintainer request; no tracking issue requested.
Changes
Release(build → qualify → publish) andPre-release(build → publish and qualify in parallel), sharing callable build, publication, and qualification workflows. Pre-release supports tag pushes and manual dispatch; Release Auto-Tag dispatches Pre-release.preinstaller alias accepts published candidates even while qualification runs or after it fails, and retains support for artifacts from the previous workflow.Testing
git diff --checkpass.Checklist