Repository navigation
ci(compatibility): require explicit risk acceptance - #4595
Merged
Merged
Conversation
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 15, 2026 10:18
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
alangou
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility reviews currently mark documented intentional changes as
ACKEDwithout linking explicit acceptance of the consumer risk, and repeat unchanged findings on successive revisions. Require an acceptance-comment or review URL, show plain-language acceptance status, and post only new or materially updated findings while retaining the complete assessment in the artifact.Related Issue
Closes #4594
The linked issue has no
state:acceptedlabel; the PR author has verified ADMIN access to NVIDIA/OpenShell.Changes
highand limit the prompt to breaking changes to existing public contracts, retaining existing compatibility evidence requirements.Testing
Passed: Ruff lint and formatting, actionlint for both affected workflows, JSON schema field consistency, and
git diff --check.A live model review was not run. Interpreting explicit acceptance and matching prior findings still depend on the reviewer; validation enforces the presence and shape of associated PR discussion links.
The local pre-commit hook failed while preparing Node/Python tooling on NixOS and was skipped with explicit author approval; the focused checks above passed separately.
Checklist