Skip to content

ci(compatibility): require explicit risk acceptance and avoid repeat reports #4594

Closed

Description

@SDAChess

User Story

While reviewing OpenShell PR #4558, I encountered compatibility reports marked ACKED without a comment explicitly accepting the affected consumer risk. I need the compatibility bot to distinguish documented intent from explicit risk acceptance and avoid repeating unchanged findings across revisions.

Description

Require a direct acceptance-comment or review link for acknowledged breaking changes. Read all PR discussion before finalizing acceptance or deciding whether a finding was already reported. Keep unchanged findings in the complete report while posting only new findings or material updates. Use high reasoning effort and limit the review to breaking changes to existing public contracts.

Context

Example: #4558 (comment). The PR description documents intentional changes, but documentation and test authorization do not explicitly accept the specific consumer risks. Existing compatibility evidence requirements remain applicable.

Definition of Done

  • Acknowledged findings require a direct comment or review URL accepting the specific break and consumer risk; no quote is needed.
  • PR descriptions, general approvals, test authorization, and previous bot claims cannot establish acceptance.
  • All discussion pages are considered; unchanged findings do not produce repeated PR comments.
  • Full reports retain outstanding findings, including previously reported ones.
  • Review uses high reasoning effort and reports breaking changes only.
  • Focused report validation and rendering regressions pass.

Activity

  1. self-assigned this
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions