Repository navigation
feat: first-run setup, first task and receipts for operation results - #268
Merged
Merged
Conversation
Replace the notices written into page bodies with a receipt overlay in the top right of the content area (docs/ui-interaction-plan.md): - FeedbackProvider, FeedbackViewport and ActionButton; launch, save, apply, delete and import results across Overview, Providers, Profiles, Agent profile, Compatibility mode, Settings, MCP and Skills now report through it - MCP and Skills no longer fail silently: read failures are told apart from empty lists, apply is held while running, and a Skill delete is removed from the list only after the backend confirms it - New launch error codes (LAUNCH_DIRECTORY_INVALID, TERMINAL_NOT_FOUND, TERMINAL_LAUNCH_FAILED) with localized copy; closing the Skill import picker is no longer reported as a failure - The legacy-migration banner becomes a one-time receipt Also includes the per-Agent compatibility-mode flow and the UI friendliness pass already on this branch, which touch the same files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ui-interaction-plan.md linked to status-dot-ui-plan.md, which exists only in a local checkout and has never been committed. The link was broken for everyone else and failed the Docs check on every pull request based on this branch. The sentence stays; only the link goes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Claude Desktop e2e test asserted that the "save changes" button was disabled after clicking it. That button is only disabled while the request is in flight; once the address is saved and nothing uses compatibility mode, the primary action becomes "turn on compatibility mode" and the button the test looked for no longer exists. A save that finished before the first poll failed the test, and the next test with it, since it relies on what this one sets up. Assert the state the page settles in instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
) The search box writes its text to the URL after a 180ms debounce. Opening a card inside that window unmounted the page, the cleanup dropped the timer, and the detail page went back to a URL without the search text. Commit the pending text before navigating to a card, and fold it into filter and history URL writes so neither write overwrites the other. URL writes now build on the latest written params rather than on the last render, which also closes the gap between a write and its render. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…#265) The wizard only mentioned compatibility mode after a connection test had failed, and that test is optional. A first-time user who picked Codex with a model service that has only confirmed Chat Completions, and skipped the test, installed an Agent that failed on its first request. The Provider step now reads the built-in protocol table and offers compatibility mode up front when the Agent's protocol is not `implementation-supported` on the selected Provider while `openai` is. No request is sent to decide this. - Parse `protocols` from providers.lock.json, validate its levels, and carry it on the Provider DTO; a custom Provider has no table and gets no hint - The hint says support is unconfirmed, not absent, and is optional: the user can continue without it. A connection test that really fails still requires choosing compatibility mode or another service - A choice made without a test survives typing and saving the key, which used to reset it; one made after a failed test is still discarded with the verdict it rested on - Regenerate the Wails bindings and update the frozen status fixture Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
The step asked for an API key without saying what one is, where it comes from, or who charges for using it. A Provider with no saved key now shows three lines under the field: what the key is, that "Get an API key" opens the Provider's own page, and that connection tests and Agent calls are real requests billed by the Provider. The billing line gives no amount and no estimate, because the price is the Provider's to state. The second line is dropped when the Provider publishes no key page, since it names a button that is then absent. Nothing is shown once a key is saved. Refs #258 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* feat: show the machine and pre-select an Agent on a first run The Agent step opened with nothing chosen and nothing said about the machine, so a new user met a list of eleven products and a disabled Continue button. A first run now arrives with WorkBuddy selected on the desktop tab, which stays the default tab. It is only a starting point: any other row can be picked, a status refresh does not put it back, and a machine that has been set up before gets no pre-selection. Above the list, a summary names the system, each runtime and how many Agents are installed. A missing runtime says whether the current choice needs it, because a desktop Agent needs none and a bare "not installed" would read as a fault. Refs #258 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * test: wait for the saved state, not the save in flight The Claude Desktop e2e test asserted that the "save changes" button was disabled after clicking it. That button is only disabled while the request is in flight; once the address is saved and nothing uses compatibility mode, the primary action becomes "turn on compatibility mode" and the button the test looked for no longer exists. A save that finished before the first poll failed the test, and the next test with it, since it relies on what this one sets up. Assert the state the page settles in instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Also keeps a select open through a scroll that did not move it: with the key explainer and the compatibility-mode hint both on the Provider step, the e2e suite could not choose a Provider. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The inherited-directory half of TestOSRunnerStartsInTheContextWorkingDirectory compared the child's directory with os.Getwd() as text. A checkout reached through a symlink, such as one under /tmp on macOS, reports the link from Getwd and the target from the child, and the test failed there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
firstRun was "~/.bootagent does not exist". The real runner logs every command under ~/.bootagent/logs, and the app runs the region probe at startup and version probes inside each status read, so that directory existed before the first status was answered. On a new machine the real app therefore never reported a first run and never opened onboarding. No test saw it: a build with an injected runner is not logged, which covers every unit test and the whole e2e suite. It showed up running the non-e2e server build against an empty home. firstRun now means nothing but the command log and the marketplace cache is in ~/.bootagent. A stored setting, Provider, Profile or anything else ends it, as before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
claude/compat-mode-flowintomain. The branch holds two changes of its own and five pull requests that were reviewed and merged into it.The branch's own commits
00f5780Report operation results as receipts without moving the page, and the compatibility-mode flow that goes with it.e4e1c38Plan for switching Agents back to their official login (docs only).fd622f8Drop a link to a plan that was never committed, which failed the Docs check.691ce99An e2e assertion that waited for a button that exists only while a save is in flight.Merged into it
#262 to #264 are work packages P0-B to P0-D of #258. P0-A landed in #259.
Refs #258
Found only once everything was together
With #263 and #265 both merged, the Provider step is tall enough to scroll, and the e2e suite could no longer choose a Provider:
SelectFieldclosed its list on a scroll that had not moved it. Each pull request had passed on its own. Fixed in the #264 merge, with a unit test.Checked on the combined tree
go test -race ./...,go vet ./...,staticcheck ./...pnpm run test(709 passed),pnpm run buildpnpm run test:e2e(16 passed)scripts/check-docs.py,scripts/generate_third_party_licenses.py --checkNot checked
00f5780ande4e1c38were not reviewed as part of this work; they are included as they were on the branch.🤖 Generated with Claude Code