Skip to content

feat: suggest compatibility mode on the Provider step before any test - #265

Merged
yujiezhang-ops merged 3 commits into
claude/compat-mode-flowfrom
feat/wizard-conversion-hint
Nov 20, 2026
Merged

yujiezhang-ops merged 3 commits into
claude/compat-mode-flowfrom
feat/wizard-conversion-hint

Conversation

@yujiezhang-ops

Copy link
Copy Markdown
Collaborator

Stacked on claude/compat-mode-flow, which is not in main yet. Review the diff against that base; this lands in main only after the base does.

Summary

The wizard only mentioned compatibility mode after a connection test had failed, and that test is optional. A first-time user who picked Codex with a Provider that has only confirmed Chat Completions, and skipped the test, installed an Agent that failed on its first request.

The Provider step now reads the built-in protocol table and offers compatibility mode up front when the Agent's protocol is not implementation-supported on the selected Provider while openai is. No request is sent to decide this.

  • protocols from providers.lock.json is now parsed, validated and carried on the Provider DTO. A custom Provider has no table and gets no hint.
  • The hint says support is unconfirmed, not absent, and is optional: the user can continue without it. A connection test that really fails still requires choosing compatibility mode or another Provider.
  • A choice made without a test now survives typing and saving the key, which used to reset it. One made after a failed test is still discarded with the verdict it rested on.
  • Wails bindings regenerated; the frozen status fixture updated.

Today this affects Codex with every built-in Provider except DeepSeek, the only one that marks Responses as implementation-supported.

Related to #258.

Checked

  • go test for internal/catalog, internal/provider, internal/app, internal/binding
  • pnpm run typecheck and pnpm run test (688 passed), rerun before opening this PR
  • pnpm run test:e2e: the full suite was run five times by the authoring session. Three runs passed; two failed in the Marketplace back-navigation test, which also fails intermittently on the base branch and is fixed separately in the Marketplace search PR

Not checked

  • The full e2e suite with that Marketplace fix applied on top of this branch.
  • Not run in a native desktop window.

Merge note

Touches ProviderKeyPage.tsx, as the API-key explainer PR does. The two merge cleanly with each other.

🤖 Generated with Claude Code

yujiezhang-ops and others added 3 commits November 19, 2026 18:14
The wizard only mentioned compatibility mode after a connection test had
failed, and that test is optional. A first-time user who picked Codex with a
model service that has only confirmed Chat Completions, and skipped the test,
installed an Agent that failed on its first request.

The Provider step now reads the built-in protocol table and offers
compatibility mode up front when the Agent's protocol is not
`implementation-supported` on the selected Provider while `openai` is. No
request is sent to decide this.

- Parse `protocols` from providers.lock.json, validate its levels, and carry
  it on the Provider DTO; a custom Provider has no table and gets no hint
- The hint says support is unconfirmed, not absent, and is optional: the
  user can continue without it. A connection test that really fails still
  requires choosing compatibility mode or another service
- A choice made without a test survives typing and saving the key, which
  used to reset it; one made after a failed test is still discarded with the
  verdict it rested on
- Regenerate the Wails bindings and update the frozen status fixture

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yujiezhang-ops
yujiezhang-ops merged commit 21b909f into claude/compat-mode-flow Nov 20, 2026
4 checks passed
@yujiezhang-ops
yujiezhang-ops deleted the feat/wizard-conversion-hint branch November 20, 2026 05:52
yujiezhang-ops added a commit that referenced this pull request Nov 20, 2026
…268)

* feat: report operation results without moving the page

Replace the notices written into page bodies with a receipt overlay in the
top right of the content area (docs/ui-interaction-plan.md):

- FeedbackProvider, FeedbackViewport and ActionButton; launch, save, apply,
  delete and import results across Overview, Providers, Profiles, Agent
  profile, Compatibility mode, Settings, MCP and Skills now report through it
- MCP and Skills no longer fail silently: read failures are told apart from
  empty lists, apply is held while running, and a Skill delete is removed
  from the list only after the backend confirms it
- New launch error codes (LAUNCH_DIRECTORY_INVALID, TERMINAL_NOT_FOUND,
  TERMINAL_LAUNCH_FAILED) with localized copy; closing the Skill import
  picker is no longer reported as a failure
- The legacy-migration banner becomes a one-time receipt

Also includes the per-Agent compatibility-mode flow and the UI friendliness
pass already on this branch, which touch the same files.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: plan switching Agents back to their official login

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: drop a link to a plan that is not in the repository

ui-interaction-plan.md linked to status-dot-ui-plan.md, which exists only
in a local checkout and has never been committed. The link was broken for
everyone else and failed the Docs check on every pull request based on
this branch. The sentence stays; only the link goes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test: wait for the saved state, not the save in flight

The Claude Desktop e2e test asserted that the "save changes" button was
disabled after clicking it. That button is only disabled while the request
is in flight; once the address is saved and nothing uses compatibility
mode, the primary action becomes "turn on compatibility mode" and the
button the test looked for no longer exists. A save that finished before
the first poll failed the test, and the next test with it, since it relies
on what this one sets up.

Assert the state the page settles in instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: keep Marketplace search text typed just before opening a card (#266)

The search box writes its text to the URL after a 180ms debounce. Opening
a card inside that window unmounted the page, the cleanup dropped the
timer, and the detail page went back to a URL without the search text.

Commit the pending text before navigating to a card, and fold it into
filter and history URL writes so neither write overwrites the other.
URL writes now build on the latest written params rather than on the
last render, which also closes the gap between a write and its render.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

* feat: suggest compatibility mode on the Provider step before any test (#265)

The wizard only mentioned compatibility mode after a connection test had
failed, and that test is optional. A first-time user who picked Codex with a
model service that has only confirmed Chat Completions, and skipped the test,
installed an Agent that failed on its first request.

The Provider step now reads the built-in protocol table and offers
compatibility mode up front when the Agent's protocol is not
`implementation-supported` on the selected Provider while `openai` is. No
request is sent to decide this.

- Parse `protocols` from providers.lock.json, validate its levels, and carry
  it on the Provider DTO; a custom Provider has no table and gets no hint
- The hint says support is unconfirmed, not absent, and is optional: the
  user can continue without it. A connection test that really fails still
  requires choosing compatibility mode or another service
- A choice made without a test survives typing and saving the key, which
  used to reset it; one made after a failed test is still discarded with the
  verdict it rested on
- Regenerate the Wails bindings and update the frozen status fixture

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

* feat: explain what an API key is on the Provider step (#263)

The step asked for an API key without saying what one is, where it comes
from, or who charges for using it.

A Provider with no saved key now shows three lines under the field: what
the key is, that "Get an API key" opens the Provider's own page, and that
connection tests and Agent calls are real requests billed by the Provider.
The billing line gives no amount and no estimate, because the price is the
Provider's to state.

The second line is dropped when the Provider publishes no key page, since
it names a button that is then absent. Nothing is shown once a key is
saved.

Refs #258

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

* feat: show the machine and pre-select an Agent on a first run (#262)

* feat: show the machine and pre-select an Agent on a first run

The Agent step opened with nothing chosen and nothing said about the
machine, so a new user met a list of eleven products and a disabled
Continue button.

A first run now arrives with WorkBuddy selected on the desktop tab, which
stays the default tab. It is only a starting point: any other row can be
picked, a status refresh does not put it back, and a machine that has been
set up before gets no pre-selection.

Above the list, a summary names the system, each runtime and how many
Agents are installed. A missing runtime says whether the current choice
needs it, because a desktop Agent needs none and a bare "not installed"
would read as a fault.

Refs #258

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test: wait for the saved state, not the save in flight

The Claude Desktop e2e test asserted that the "save changes" button was
disabled after clicking it. That button is only disabled while the request
is in flight; once the address is saved and nothing uses compatibility
mode, the primary action becomes "turn on compatibility mode" and the
button the test looked for no longer exists. A save that finished before
the first poll failed the test, and the next test with it, since it relies
on what this one sets up.

Assert the state the page settles in instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

* feat: offer a first task after Codex or Claude Code installs (#264)

Also keeps a select open through a scroll that did not move it: with the key explainer and the compatibility-mode hint both on the Provider step, the e2e suite could not choose a Provider.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test: compare working directories with symlinks resolved

The inherited-directory half of TestOSRunnerStartsInTheContextWorkingDirectory
compared the child's directory with os.Getwd() as text. A checkout reached
through a symlink, such as one under /tmp on macOS, reports the link from
Getwd and the target from the child, and the test failed there.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix: report a first run until the user has stored something

firstRun was "~/.bootagent does not exist". The real runner logs every
command under ~/.bootagent/logs, and the app runs the region probe at
startup and version probes inside each status read, so that directory
existed before the first status was answered. On a new machine the real
app therefore never reported a first run and never opened onboarding.

No test saw it: a build with an injected runner is not logged, which
covers every unit test and the whole e2e suite. It showed up running the
non-e2e server build against an empty home.

firstRun now means nothing but the command log and the marketplace cache
is in ~/.bootagent. A stored setting, Provider, Profile or anything else
ends it, as before.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant