uvloop build failed on Python 3.8 #277

Activity

1. sonirico commented on Oct 16, 2019

   

   sonirico

   on Oct 16, 2019

   Last edited by sonirico

   More actions

   Same here, same platform, uvloop and python version: https://travis-ci.com/sonirico/wpoke/jobs/246022440
   This is a big stopper in regards to make libraries take advantage of the new features introduced in py38. Fast feedback on this is much appreciated...

   👍React with 👍6Reacted by Vladislav Yarmak, atezerjani, Alexey Zinoviev, BeatButton, h1nk and Andrey Semakin
2. Jamim commented on Oct 16, 2019

   

   Jamim

   on Oct 16, 2019

   More actions

   It looks like this issue duplicates #266.
3. Snawoot commented on Oct 16, 2019

   

   Snawoot

   on Oct 16, 2019

   Author

   More actions

   @Jamim Yes, it is, but this issue also escalates problem. Now uvloop is not usable on current stable python.

   👍React with 👍17Reacted by Aliaksei Urbanski, Marquitos, Alexandre Yukio Harano, h1nk, Juan Calderon-Perez, 이정민(Jeong-Min Lee) / Merchant, atezerjani, Michał Wieluński, Fernando Mayo, fenchu and 7 more
5. 1st1 commented on Oct 21, 2019

   

   1st1

   on Oct 21, 2019

   Member

   More actions

   Quick update: I'll try to find time to release a new version in a couple of days. Thanks for confirming that Cython 0.29.13 works.

   👍React with 👍4Reacted by Fernando Mayo, Dan Stephenson, Andrey Oleynik and Han
6. ndaidong commented on Oct 21, 2019

   

   ndaidong

   on Oct 21, 2019

   More actions

   @speedyb0y what did you do exactly? Within virtual environment created with python 3.8, I tried to install cython 0.29.3 first, then install uvloop. It sill fails.

   Installing collected packages: uvloop
       Running setup.py install for uvloop ... error
       ERROR: Command errored out with exit status 1:
        command: /workspace/awl/abms-v2/venv/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-2ej5cuaf/uvloop/setup.py'"'"'; __file__='"'"'/tmp/pip-install-2ej5cuaf/uvloop/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-yawpg18_/install-record.txt --single-version-externally-managed --compile --install-headers /workspace/awl/abms-v2/venv/include/site/python3.8/uvloop
            cwd: /tmp/pip-install-2ej5cuaf/uvloop/
       Complete output (1175 lines):
       running install
       running build
       running build_py
       creating build
       creating build/lib.linux-x86_64-3.8
       creating build/lib.linux-x86_64-3.8/uvloop
       copying uvloop/_noop.py -> build/lib.linux-x86_64-3.8/uvloop
   ################################################################
   # stripped....
   ################################################################
         CC       src/unix/libuv_la-procfs-exepath.lo
         CC       src/unix/libuv_la-proctitle.lo
         CC       src/unix/libuv_la-sysinfo-loadavg.lo
         CCLD     libuv.la
       ar: `u' modifier ignored since `D' is the default (see `U')
       building 'uvloop.loop' extension
       creating build/temp.linux-x86_64-3.8
       creating build/temp.linux-x86_64-3.8/uvloop
       gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/workspace/awl/abms-v2/venv/include -I/usr/local/include/python3.8 -I/tmp/pip-install-2ej5cuaf/uvloop/vendor/libuv/include -c uvloop/loop.c -o build/temp.linux-x86_64-3.8/uvloop/loop.o -O2
       uvloop/loop.c: In function ‘__Pyx_InitCachedConstants’:
       /usr/local/include/python3.8/code.h:72:25: warning: passing argument 6 of ‘PyCode_New’ makes pointer from integer without a cast [-Wint-conversion]
        #define CO_OPTIMIZED    0x0001
                                ^
       uvloop/loop.c:334:37: note: in definition of macro ‘__Pyx_PyCode_New’
                  PyCode_New(a, 0, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
                                            ^
       uvloop/loop.c:154727:63: note: in expansion of macro ‘CO_OPTIMIZED’
          __pyx_codeobj__13 = (PyObject*)__Pyx_PyCode_New(1, 0, 3, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_tuple__12, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_uvloop_loop_pyx, __pyx_n_s_callback, 850, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj__13)) __PYX_ERR(2, 850, __pyx_L1_error)
                                                                      ^~~~~~~~~~~~
       In file included from /usr/local/include/python3.8/compile.h:5,
                        from /usr/local/include/python3.8/Python.h:138,
                        from uvloop/loop.c:20:
       /usr/local/include/python3.8/code.h:122:28: note: expected ‘PyObject *’ {aka ‘struct _object *’} but argument is of type ‘int’
        PyAPI_FUNC(PyCodeObject *) PyCode_New(
                                   ^~~~~~~~~~
       uvloop/loop.c:154727:230: warning: passing argument 14 of ‘PyCode_New’ makes integer from pointer without a cast [-Wint-conversion]
          __pyx_codeobj__13 = (PyObject*)__Pyx_PyCode_New(1, 0, 3, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_tuple__12, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_uvloop_loop_pyx, __pyx_n_s_callback, 850, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj__13)) __PYX_ERR(2, 850, __pyx_L1_error)
                                                                                                                                                                                                                                             ^~~~~~~~~~~~~~~~~~
       uvloop/loop.c:334:69: note: in definition of macro ‘__Pyx_PyCode_New’
                  PyCode_New(a, 0, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
                                                                            ^~~~
       In file included from /usr/local/include/python3.8/compile.h:5,
                        from /usr/local/include/python3.8/Python.h:138,
                        from uvloop/loop.c:20:
       /usr/local/include/python3.8/code.h:122:28: note: expected ‘int’ but argument is of type ‘PyObject *’ {aka ‘struct _object *’}
        PyAPI_FUNC(PyCodeObject *) PyCode_New(
                                   ^~~~~~~~~~
       uvloop/loop.c:154727:250: warning: passing argument 15 of ‘PyCode_New’ makes pointer from integer without a cast [-Wint-conversion]
   
7. imbolc commented on Oct 21, 2019

   

   imbolc

   on Oct 21, 2019

   Last edited by imbolc

   More actions

   @ndaidong I guess he used master's version:

   pip install git+https://github.com/MagicStack/uvloop
   
8. h1nk commented on Oct 21, 2019

   

   h1nk

   on Oct 21, 2019

   Last edited by h1nk

   More actions

   @ndaidong see this comment & insurgency/aioa2squery@9e63733
10. ndaidong commented on Oct 22, 2019

    

    ndaidong

    on Oct 22, 2019

    Last edited by ndaidong

    More actions

    @imbolc @h1nk @speedyb0y : thank you all for your replies
    I confirmed that uvloop from its master branch works for me. Just need to install latest version of Cython first, then run the command like imbolc's suggestion.
    Another way that helps to install it faster is build uvloop first (similar to my fork), then use it later without Cython and rebuilding.
11. shusso commented on Oct 22, 2019

    

    shusso

    on Oct 22, 2019

    More actions

    Just confirming that uvloop master + python3.8 seems to work (in the python3.8 docker image):

    FROM python:3.8.0-slim-buster
    
    ADD ./requirements.txt /
    
    RUN apt-get update -y
    RUN apt-get install -y gcc git build-essential libtool automake
    RUN pip3 install Cython
    RUN pip3 install git+https://github.com/MagicStack/uvloop
    ...
    

    👍React with 👍2Reacted by Aliaksei Urbanski and Yoonseop Kang
12. 1st1 commented on Oct 24, 2019

    

    1st1

    on Oct 24, 2019

    Last edited by 1st1

    Member

    More actions

    I do not recommend running uvloop 0.13 on 3.8. It is broken in many subtle ways. A proper release is coming soon, please wait.

    👍React with 👍8Reacted by Ian Woloschin, Darin Gordon, Anton Ilyushenkov, Vladislav Yarmak, Markus, krp, Dmytro Kovalchuk and Youri Ackx
13. 1st1

    added

    fixed in master

    on Oct 24, 2019
14. 1st1 commented on Oct 25, 2019

    

    1st1

    on Oct 25, 2019

    Member

    More actions

    I've just published https://github.com/MagicStack/uvloop/releases/tag/v0.14.0rc1. Please test. The final release will be published some time next week if RC1 is OK.

    👍React with 👍2Reacted by Vladislav Yarmak and Aliaksei Urbanski
15. 1st1

    closed this as completedon Oct 25, 2019
16. Snawoot commented on Oct 26, 2019

    

    Snawoot

    on Oct 26, 2019

    Author

    More actions

    My test suite is passing. Thank you! Looking forward for PyPI release.
17. 1st1 commented on Oct 26, 2019

    

    1st1

    on Oct 26, 2019

    Member

    More actions

    Thank you! Looking forward for PyPI release.

    You can install with pip install uvloop==0.14.0rc1

    👍React with 👍8Reacted by Aliaksei Urbanski, Marwan Rabbâa, David Underhill, Zev Averbach, krp, Mantas Zimnickas, playwhyyza and Megidd

    ❤️React with ❤️1Reacted by Megidd
18. pauldraper commented on Apr 23, 2021

    

    pauldraper

    on Apr 23, 2021

    More actions

    Is pip install uvloop==0.14.0rc1 still the expected way to install?
19. fantix commented on Apr 26, 2021

    

    fantix

    on Apr 26, 2021

    Member

    More actions

    @pauldraper we now have 0.14.0 and 0.15.2, both should work for Python 3.8 I believe.

    👍React with 👍2Reacted by Megidd and Aliaksei Urbanski

    😕React with 😕1Reacted by Mohammed Rahman Sherif

    ❤️React with ❤️1Reacted by Megidd