Repository navigation
issue building in Python 3.8.0b4+ (a recent development version) #266
Description
- uvloop version: 0.13.0
- Python version: 3.8.0b4+
- Platform: travis-ci, Ubuntu xenial 16.04.6
- Can you reproduce the bug with
PYTHONASYNCIODEBUGin env?: dunno
Python 3.8 development has reached the point where it has breaking changes.
PyCode_New() seems to have changed function signature.
uvloop/loop.c:334:11: error: too many arguments to function ‘PyCode_New’
PyCode_New(a, 0, k, l, s, f, code, c, n, v, fv, cell, fn, name, fline, lnos)
^
uvloop/loop.c:154727:34: note: in expansion of macro ‘__Pyx_PyCode_New’
__pyx_codeobj__13 = (PyObject*)__Pyx_PyCode_New(1, 0, 3, 0, CO_OPTIMIZED|CO_NEWLOCALS, __pyx_empty_bytes, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_tuple__12, __pyx_empty_tuple, __pyx_empty_tuple, __pyx_kp_s_uvloop_loop_pyx, __pyx_n_s_callback, 850, __pyx_empty_bytes); if (unlikely(!__pyx_codeobj__13)) __PYX_ERR(2, 850, __pyx_L1_error)
^
In file included from /opt/python/3.8-dev/include/python3.8/compile.h:5:0,
from /opt/python/3.8-dev/include/python3.8/Python.h:138,
from uvloop/loop.c:20:
/opt/python/3.8-dev/include/python3.8/code.h:122:28: note: declared here
PyAPI_FUNC(PyCodeObject *) PyCode_New(
^
In the past with other projects, the issue was that CPython output was checked-in and needed to be re-generated.
For an example from the Python 3.7 era: yaml/pyyaml#69
And an example with Python 3.8, this time the CPython people changed their minds back: yaml/pyyaml#322
Activity
1st1 commentedon Aug 31, 2019
We probably need to use a newer Cython. We'll do so soon.
RobertoPrevato commentedon Sep 1, 2019
I just compiled uvloop for Python 3.8, I didn't have issues using Cython 0.29.13. (Updating my comment because it referred to another issue).
Added explicit support for Python 3.8
Update Cython for 3.8 compatibility
Update Cython for 3.8 compatibility
📌 remove uvloop dependency until uvloop build is fixed
1st1 commentedon Oct 24, 2019
I do not recommend running uvloop 0.13 on 3.8. It is broken in many subtle ways. A proper release is coming soon, please wait.
1st1 commentedon Oct 25, 2019
I've just published https://github.com/MagicStack/uvloop/releases/tag/v0.14.0rc1. Please test. The final release will be published some time next week if RC1 is OK.