Repository navigation
Include build details on the instantiation event - #38
Merged
Merged
Conversation
Adds the build number and the LoopWorkspace and Loop git branch and revision from BuildDetails.plist, so builds sharing a version string can be told apart. This event is sent at the version-only sharing level.
Sends the identifiers Loop's build-details script collected from .loopcustomization marker files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #36 from next-dev; both commits are clean cherry-picks.
The "LoopKitAnalytics instantiation" event now carries the build number and the LoopWorkspace and Loop git branch and revision from BuildDetails.plist, so builds that share a version string can be told apart. It also passes along
com-loopkit-Loop-customizations, which dev's build script doesn't write yet, so that property is absent on dev until LoopKit/Loop#2583 is backported. This event is sent at the version-only sharing level.