Repository navigation
Include build details on the instantiation event - #36
Merged
Merged
Conversation
Adds the build number and the LoopWorkspace and Loop git branch and revision from BuildDetails.plist, so builds sharing a version string can be told apart. This event is sent at the version-only sharing level.
Sends the identifiers Loop's build-details script collected from .loopcustomization marker files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LoopKitAnalytics instantiationevent, the only event sent at the "share version only" level, now carries properties that tell apart builds sharing a version string:buildNumber:CFBundleVersionworkspaceBranch,workspaceRevision: LoopWorkspace git branch and short SHA (the branch is absent when the workspace is on a detached HEAD)loopBranch,loopRevision: Loop submodule git branch and short SHAcustomizations: identifiers of the build customizations applied, collected from.loopcustomizationmarker files (Record build customizations in BuildDetails.plist Loop#2577)The values come from the app's
Info.plistandBuildDetails.plist. Properties missing fromBuildDetails.plistare left out. The source path and per-submodule details in that file aren't sent.The workspace build succeeds. Not yet checked on a device: the simulator never creates the analytics client.