Repository navigation
Use the cgm event upload key and continue with cgm events in uploadCgmEventData - #2636
Merged
Merged
Conversation
…mEventData The cgm event upload counted failures against the pump event task and, when more cgm events remained than one batch, ran the pump event upload again instead of fetching the next cgm event batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uploadCgmEventDatawas copied fromuploadPumpEventDataand kept two pump-event references:UploadTaskKeyused.pumpEvent, so CGM event upload failures were counted and retried against the pump event taskuploadPumpEventData(to:), so when more CGM events remained than one batch, the next batch waited for the next upload trigger while pump events were re-uploadedBoth now use the CGM event path, and the error log says "cgm event". The dispatch queue and query anchor already used
.cgmEvent.Verified that Loop builds;
RemoteDataServicesManagerhas no unit tests.