Repository navigation
Include override history in the critical event logs - #2616
Merged
Merged
Conversation
Exports gain Overrides.json (LoopKit/LoopKit#668).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the override history to the logs that Export Critical Event Logs writes, so each day's archive gains
Overrides.json.Requires LoopKit/LoopKit#668, which makes
TemporaryScheduleOverrideHistoryaCriticalEventLog.Each day's archive is written once and kept, so days exported before this change won't have
Overrides.jsonuntil they're purged. Days exported after it will.Testing: in the iOS simulator I started the Walking preset and ran Settings → Report a Problem → Export Critical Event Logs. Today's archive had
Overrides.jsoncontaining the Walking override, next to the other logs.