Repository navigation
SettingsManagerTests: only wait for the settings manager's notification - #2566
Merged
Merged
Conversation
testChangingMaxBasalUpdatesLoopData fulfilled its expectation on any LoopDataUpdated notification. The test host is a running Loop app, whose own LoopDataManager posts that notification too, so the expectation was fulfilled twice and XCTest aborted the host, failing the CI run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testChangingMaxBasalUpdatesLoopDatafulfilled its expectation on any.LoopDataUpdatednotification. The test host is a running Loop app whose ownLoopDataManagerposts that notification too, so the expectation was fulfilled twice and XCTest aborted the host. That's the other crash keeping LoopKit/LoopWorkspace#523 red.Now it observes only notifications from the
SettingsManagerunder test. Passes on the iOS 27 simulator.