Skip to content

Fix CI regarding installation of Clang 16 + start covering Clang 17 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hartwork merged 4 commits into from
Feb 2, 2023
Merged

Fix CI regarding installation of Clang 16 + start covering Clang 17 #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53ba68b
Actions (Linux): Fix installation of Clang 16
hartwork Feb 2, 2023
3a60ce5
Actions (Linux): Start covering Clang 17
hartwork Feb 2, 2023
682ca9b
lv-tool: Address Clang 17 warning -Wtautological-unsigned-enum-zero-c…
hartwork Feb 2, 2023
4245282
lv-tool: Use static_cast for existing "SDL_GLattr (-1)"
hartwork Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ jobs:
- cc: clang-16
cxx: clang++-16
clang_major_version: 16
clang_repo_suffix: -16
- cc: clang-17
cxx: clang++-17
clang_major_version: 17
clang_repo_suffix:
steps:
- name: Add Clang/LLVM repositories
Expand Down
38 changes: 19 additions & 19 deletions libvisual/tools/lv-tool/display/sdl_driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,24 +33,24 @@
namespace {

SDL_GLattr const sdl_gl_attribute_map[] = {
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_NONE
SDL_GL_BUFFER_SIZE, // VISUAL_GL_ATTRIBUTE_BUFFER_SIZE
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_LEVEL
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_RGBA
SDL_GL_DOUBLEBUFFER, // VISUAL_GL_ATTRIBUTE_DOUBLEBUFFER
SDL_GL_STEREO, // VISUAL_GL_ATTRIBUTE_STEREO
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_AUX_BUFFERS
SDL_GL_RED_SIZE, // VISUAL_GL_ATTRIBUTE_RED_SIZE
SDL_GL_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_GREEN_SIZE
SDL_GL_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_BLUE_SIZE
SDL_GL_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ALPHA_SIZE
SDL_GL_DEPTH_SIZE, // VISUAL_GL_ATTRIBUTE_DEPTH_SIZE
SDL_GL_STENCIL_SIZE, // VISUAL_GL_ATTRIBUTE_STENCIL_SIZE
SDL_GL_ACCUM_RED_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GLattr (-1) // VISUAL_GL_ATTRIBUTE_LAST
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_NONE
SDL_GL_BUFFER_SIZE, // VISUAL_GL_ATTRIBUTE_BUFFER_SIZE
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_LEVEL
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_RGBA
SDL_GL_DOUBLEBUFFER, // VISUAL_GL_ATTRIBUTE_DOUBLEBUFFER
SDL_GL_STEREO, // VISUAL_GL_ATTRIBUTE_STEREO
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_AUX_BUFFERS
SDL_GL_RED_SIZE, // VISUAL_GL_ATTRIBUTE_RED_SIZE
SDL_GL_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_GREEN_SIZE
SDL_GL_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_BLUE_SIZE
SDL_GL_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ALPHA_SIZE
SDL_GL_DEPTH_SIZE, // VISUAL_GL_ATTRIBUTE_DEPTH_SIZE
SDL_GL_STENCIL_SIZE, // VISUAL_GL_ATTRIBUTE_STENCIL_SIZE
SDL_GL_ACCUM_RED_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
static_cast<SDL_GLattr> (-1) // VISUAL_GL_ATTRIBUTE_LAST
};

void get_nearest_resolution (int& width, int& height);
Expand Down Expand Up @@ -117,7 +117,7 @@ namespace {
for (unsigned int i = VISUAL_GL_ATTRIBUTE_NONE; i < VISUAL_GL_ATTRIBUTE_LAST; i++) {
SDL_GLattr sdl_attribute = sdl_gl_attribute_map[vidoptions->gl_attrs[i].attribute];

if (sdl_attribute < 0) {
if (sdl_attribute == static_cast<SDL_GLattr> (-1)) {
continue;
}

Expand Down
38 changes: 19 additions & 19 deletions libvisual/tools/lv-tool/display/stdout_sdl_driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,24 +44,24 @@
namespace {

SDL_GLattr const sdl_gl_attribute_map[] = {
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_NONE
SDL_GL_BUFFER_SIZE, // VISUAL_GL_ATTRIBUTE_BUFFER_SIZE
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_LEVEL
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_RGBA
SDL_GL_DOUBLEBUFFER, // VISUAL_GL_ATTRIBUTE_DOUBLEBUFFER
SDL_GL_STEREO, // VISUAL_GL_ATTRIBUTE_STEREO
SDL_GLattr (-1), // VISUAL_GL_ATTRIBUTE_AUX_BUFFERS
SDL_GL_RED_SIZE, // VISUAL_GL_ATTRIBUTE_RED_SIZE
SDL_GL_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_GREEN_SIZE
SDL_GL_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_BLUE_SIZE
SDL_GL_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ALPHA_SIZE
SDL_GL_DEPTH_SIZE, // VISUAL_GL_ATTRIBUTE_DEPTH_SIZE
SDL_GL_STENCIL_SIZE, // VISUAL_GL_ATTRIBUTE_STENCIL_SIZE
SDL_GL_ACCUM_RED_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GLattr (-1) // VISUAL_GL_ATTRIBUTE_LAST
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_NONE
SDL_GL_BUFFER_SIZE, // VISUAL_GL_ATTRIBUTE_BUFFER_SIZE
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_LEVEL
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_RGBA
SDL_GL_DOUBLEBUFFER, // VISUAL_GL_ATTRIBUTE_DOUBLEBUFFER
SDL_GL_STEREO, // VISUAL_GL_ATTRIBUTE_STEREO
static_cast<SDL_GLattr> (-1), // VISUAL_GL_ATTRIBUTE_AUX_BUFFERS
SDL_GL_RED_SIZE, // VISUAL_GL_ATTRIBUTE_RED_SIZE
SDL_GL_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_GREEN_SIZE
SDL_GL_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_BLUE_SIZE
SDL_GL_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ALPHA_SIZE
SDL_GL_DEPTH_SIZE, // VISUAL_GL_ATTRIBUTE_DEPTH_SIZE
SDL_GL_STENCIL_SIZE, // VISUAL_GL_ATTRIBUTE_STENCIL_SIZE
SDL_GL_ACCUM_RED_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_GREEN_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_BLUE_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
SDL_GL_ACCUM_ALPHA_SIZE, // VISUAL_GL_ATTRIBUTE_ACCUM_RED_SIZE
static_cast<SDL_GLattr> (-1) // VISUAL_GL_ATTRIBUTE_LAST
};

void get_nearest_resolution (int& width, int& height);
Expand Down Expand Up @@ -131,7 +131,7 @@ namespace {
SDL_GLattr sdl_attribute =
sdl_gl_attribute_map[vidoptions->gl_attrs[i].attribute];

if (sdl_attribute < 0) {
if (sdl_attribute == static_cast<SDL_GLattr> (-1)) {
continue;
}

Expand Down