Repository navigation
Fix CI regarding installation of Clang 16 + start covering Clang 17 - #235
Merged
Merged
Conversation
kaixiong
reviewed
Feb 2, 2023
| sdl_gl_attribute_map[vidoptions->gl_attrs[i].attribute]; | ||
|
|
||
| if (sdl_attribute < 0) { | ||
| if (sdl_attribute == SDL_GLattr(-1)) { |
Member
There was a problem hiding this comment.
This should also use static_cast.
kaixiong
reviewed
Feb 2, 2023
| SDL_GLattr sdl_attribute = sdl_gl_attribute_map[vidoptions->gl_attrs[i].attribute]; | ||
|
|
||
| if (sdl_attribute < 0) { | ||
| if (sdl_attribute == SDL_GLattr(-1)) { |
Member
There was a problem hiding this comment.
This should use static_cast instead:
if (sdl_attribute == static_cast<SDL_GLattr> (-1)) {
hartwork
force-pushed
the
fix-ci-regarding-clang-16
branch
from
February 2, 2023 18:30
ed2dab7 to
4245282
Compare
kaixiong
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of 0.4.x pull request #231 to
master