Repository navigation
[0.4.x] libvisual-plugins: Fix ALSA input plugin - #154
Merged
Merged
Conversation
hartwork
force-pushed
the
0.4.x-fix-alsa-input
branch
from
January 13, 2023 22:04
6387398 to
295d0d1
Compare
With 2 channels and 24 bit (3 byte) per sample per channel, each frame consists of 6 bytes. Related: https://www.alsa-project.org/wiki/FramesPeriods
hartwork
force-pushed
the
0.4.x-fix-alsa-input
branch
from
January 14, 2023 16:03
295d0d1 to
271e815
Compare
Member
Author
|
@kaixiong conflicts fixed and rebased onto latest |
kaixiong
reviewed
Jan 14, 2023
kaixiong
reviewed
Jan 14, 2023
| } | ||
|
|
||
| tmp = 1000000*4; | ||
| tmp = 1000 * 1000 / inp_alsa_var_samplerate * inp_alsa_var_frames_target; // in micro seconds |
Member
There was a problem hiding this comment.
This suffers from the integer division problem above.
kaixiong
reviewed
Jan 14, 2023
hartwork
force-pushed
the
0.4.x-fix-alsa-input
branch
from
January 14, 2023 19:44
271e815 to
7e8d9d7
Compare
hartwork
force-pushed
the
0.4.x-fix-alsa-input
branch
from
January 14, 2023 19:49
7e8d9d7 to
dc6e9c5
Compare
kaixiong
approved these changes
Jan 14, 2023
kaixiong
left a comment
kaixiong
left a comment
Member
There was a problem hiding this comment.
Nice work. Looks like it also fixes a leak with strdup() on the ALSA device string.
Member
Author
|
@kaixiong glad you like it, thanks for the review! Let me check how much can and needs to be forward-ported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should ideally be merged after pull request #152 or it will further increase the buffer overflow problem that #152 is fixing.