Repository navigation
[0.4.x] libvisual: Fix splitting of interleaved stereo - #152
Merged
Merged
Conversation
grandchild
suggested changes
Jan 8, 2023
grandchild
left a comment
grandchild
left a comment
There was a problem hiding this comment.
a small typo and extra space in the commit message:
-odd number of samples. Thanks to AddressSanatizer!
+odd number of samples. Thanks to AddressSanitizer!(but maybe that space is intentional?)
hartwork
force-pushed
the
0.4.x-fix-splitting-of-interleaved-stereo
branch
from
January 8, 2023 23:38
09fc2e5 to
5b01fa7
Compare
Previously, twice as many bytes as available were read and written (heap-buffer-overflow) and the code was not robust towards and odd number of samples. Thanks to AddressSanitizer! The two calls to visual_buffer_set_destroyer were dropped because visual_buffer_new_allocate in macro STEREO_INTERLEAVED is already setting visual_buffer_destroyer_free as a destroyer.
hartwork
force-pushed
the
0.4.x-fix-splitting-of-interleaved-stereo
branch
from
January 8, 2023 23:38
5b01fa7 to
4850128
Compare
Member
Author
@grandchild I keep looking up the spelling of sanitizer and still it's hard to get right, good catch! 👍 Thanks for the review! 🙏 |
grandchild
approved these changes
Jan 9, 2023
grandchild
left a comment
grandchild
left a comment
There was a problem hiding this comment.
mnemonic: "same as 'sanitäter' in german" 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, twice as many bytes as available were read and written (heap-buffer-overflow) and the code was not robust towards and odd number of samples. Thanks to AddressSanitizer!