Repository navigation
Raise the Repair and base-move budgets to 5 - #95
Merged
Merged
Conversation
A flaky CI or a busy Base branch is less likely to fail a Run that could have succeeded. Tests, README and site now state 5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Run now allows up to 5 Repairs and up to 5 rounds after the Base branch moves while CI runs, instead of 3.
The README and the site (unit 4 text and the illustrative Failed run) now say 5. The tests that assert the caps now expect 5 and have names that don't include the number.
Evidence
Before: with the tests updated to 5 and the code still at 3,
cargo test --test cifailed:red_ci_after_the_last_repair_is_a_failed_runexpected 6 sessions (implement + 5 Repairs) but got 4.conflict_and_ci_fix_repairs_share_one_capexpected a conflict Repair plus 4 CI-fix Repairs before "repairs exhausted: conflict" but got fewer.After:
cargo testpasses in full. It includes:fails_when_the_base_branch_keeps_moving_during_the_ci_wait, which asserts 5 merges and then "merged it again 5 times".cargo clippy --all-targetsis clean.Merge Danger
Door: two-way
Revert the two constants.
Blast Radius: small
A Failed run can now start up to 2 more agent sessions before it gives up, which means more time and API cost on runs that were going to fail anyway.
Unaddressed findings
Standards
tests/ci.rs,tests/mergeable.rs): not changed. The caps are private tosrc/run.rsand the integration tests are black-box, so spelling out the expected counts is intended.Spec
docs/research/thirdshift-site-prototype-handback.md:42still quotes "starting Repair n of 3": not changed. It is a research handback recording what was checked at that time, so it's historical likedocs/grilling.md.Closes #90
🤖 Generated with Claude Code