Repository navigation
Wait for a fragment link's target to open in the browser test - #685
Merged
Merged
Conversation
The page reveals a newly linked fragment on hashchange, which Chrome can deliver after Playwright's click returns. On GitHub's runners it always did, so the immediate isVisible() check failed site-test on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Closed
This was referenced Oct 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site-testhas failed onmainsince #684. The fragment-link test checks visibility right after clickingCREDITS.md, but the page opens the folds onhashchange. On GitHub's runners that event always arrived after Playwright's click returned.The repeated-link check further down stays a snapshot: that path reveals synchronously in the click listener.
Evidence
site-testred on main and on all three attempts of Fold Prompts and skills sections by default #684's run, each time withfalse !== trueatprompts.test.cjs:87. Locally, delaying the page'shashchangehandler by 50 ms reproduces the same assertion failure.After: the same 50 ms delay passes, and
npm test --prefix sitepasses 3/3 locally. This PR's ownsite-testrun is the CI check.Merge Danger
Door: two-way
Test-only change.
Blast Radius: site-test
🤖 Generated with Claude Code