Repository navigation
Fold Prompts and skills sections by default - #684
Merged
Merged
Conversation
This was referenced Oct 14, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All headed content on the Prompts and skills page starts folded closed. Click a heading to open or close it; native keyboard controls work without JavaScript. Fragment links reveal their target and its containing sections.
The generated fragment is regenerated from
src/prompts_page.rs. Browser tests run in CI.Closes #683
Evidence
npm test --prefix sitefailed withcommand-title must control a closed section.After: all three browser tests pass: every h2/h3/h4 toggles independently, fragment links reveal nested content, and mobile keyboard controls work with JavaScript disabled.
node --test --test-name-pattern='fragment links' site/tests/prompts.test.cjsfailed because the linked Resume text was hidden.After: the same command passes, including a repeated link to a manually closed supporting file.
cargo test --bin thirdshift prompts_page: 10 passed.cargo check --all-targets,cargo fmt --check, andcargo clippy --all-targets -- -D warningspass.cargo test: full Rust suite passed.Test seams: the served
/prompts/page's heading disclosures, browser fragment navigation, and keyboard interaction without JavaScript; the existing generated-page golden test.Merge Danger
Door: two-way
Static markup, CSS and JavaScript can be reverted; no stored data changes.
Blast Radius: Site
Shared site assets gain disclosure styles and fragment handling. CI gains a Chromium browser-test job.
Unaddressed findings
Standards
None. The sole finding, S1 (P3, duplicated browser-test lifecycle), is addressed by
pageForTestand its test-context cleanup. All three tests pass after the refactor.Spec
None; the independent review found no missing requirements, scope creep or wrong implementation.
Both axes read all 10 changed files. Changed files left unread: none.
Security
None. Guidance-mode review of
69fde3bb5b3ed9c2bd7c2132c3cfadda5173192a...HEADfound no introduced security findings requiring a fix. Reviewed all 10 changed files and supporting generator escaping, shared JavaScript, local test-server routing, and site deployment code against the client-side, HTTP, and supply-chain attack-class guidance. No repositorySECURITY.mdor threat-model file was present.Validation ran locally with external networking disabled, read-only inputs, an empty allowlisted environment, scratch-only storage, and enforced resource limits: all 3 browser tests and all 10 existing Rust
prompts_pagetests passed. No source fixes were needed.Built with codex · gpt-6.1-sol · high
Security review outcome
No unaddressed introduced findings.
CI notes
site-test: flaky visibility assertion atsite/tests/prompts.test.cjs:87races the queuedhashchangehandler; reproduced locally with the content becoming visible without another click, while all three tests pass locally on CI's Node 24.21.0 (the unchanged CI rerun hit the same race); code and tests left unchanged.