Skip to content

Track reviewer file coverage and retry unread files once - #498

Merged
JacobStephens2 merged 3 commits into
issue-486from
issue-489
Oct 7, 2026
Merged

JacobStephens2 merged 3 commits into
issue-486from
issue-489

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Both review briefs request files-read lists. The review compares each axis's list with changed files, closes gaps once, and names anything still unread. Reviewing Session prompts require those unread files in the pull request body.

for each axis (Standards, Spec)
  report files read
  compare with changed files
  if gaps: one follow-up (fresh reviewer if the Harness requires it)
  combine findings and files read
  name remaining unread files, or say none
Session prompt → disclose unread changed files in the PR body

Regenerated the Prompts and skills page and Markdown prompts. The instruction covers fresh and Continuation implement sessions, Spec review, and Foreign-commit Repair; Continuation has two rendered variants.

Closes #489

Evidence

  • Before: git show issue-486:src/prompt.rs | rg -n 'Name in the pull request body any changed file the review left unread' finds no instruction (exit 1).
    After: the sentence appears in all five affected Markdown prompt variants; all eight cargo test --bin thirdshift prompts_page checks pass, including both generated-output golden checks.

  • Before: reviewers did not report file coverage or close unread-file gaps.
    After: this branch's separate Standards and Spec reviewers each reported reading all nine changed files; neither raised a finding or left an unread file.

  • All 19 cargo test --test fresh_run tests pass, including gives_the_agent_the_fresh_prompt.

  • cargo fmt --check, cargo check --all-targets, cargo clippy --all-targets -- -D warnings, and cargo test pass (1,341 passed, 0 failed, 1 ignored).

  • CI is green on 9ab61c8: Linux, macOS, and both release artifact builds.

Test seams

  • Generated Prompts and skills page and prompts/, through their existing golden-file tests.
  • The fresh Session prompt delivered to the fake Harness, through fresh_run::gives_the_agent_the_fresh_prompt.
  • The review skill's wording is checked by Spec review, as Evidence-backed review findings #486 specifies.

Merge Danger

Door: two-way

Revert the prompt and Factory skill changes and regenerate their outputs.

Blast Radius: review

Changes the review procedure and the instructions carried by reviewing Session prompts.

Unaddressed findings

Standards

None; the reviewer raised no findings.

Spec

None; the reviewer raised no findings.

Unread changed files

Axis Changed files read Still unread
Standards 9/9 None
Spec 9/9 None

Both reviewers read these changed files:

  • prompts/continuation-pr.md
  • prompts/continuation.md
  • prompts/fresh.md
  • prompts/review-repair.md
  • prompts/spec-review.md
  • site/prompts/index.html
  • skills/thirdshift-code-review/SKILL.md
  • src/prompt.rs
  • tests/fresh_run.rs

Reviewed the whole branch against issue-486, pinned at ec45562d3fe802ba3e450226b82a10e53165f475. Generated files were read through changed hunks and relevant surrounding context. Neither axis needed a follow-up.

Built with codex · gpt-6.1-sol · xhigh

…g to fix on the branch)

2026-10-07T06:49:26Z, host thirdshift. Uncommitted work at the time of failure is included in this commit.
2026-10-07T11:59:05Z, host thirdshift. Uncommitted work at the time of failure is included in this commit.
@JacobStephens2
JacobStephens2 marked this pull request as ready for review October 7, 2026 12:11
@JacobStephens2
JacobStephens2 merged commit 501cb04 into issue-486 Oct 7, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-489 branch October 7, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant