Repository navigation
Track reviewer file coverage and retry unread files once - #498
Merged
Merged
Conversation
…g to fix on the branch) 2026-10-07T06:49:26Z, host thirdshift. Uncommitted work at the time of failure is included in this commit.
JacobStephens2
marked this pull request as draft
October 7, 2026 06:49
2026-10-07T11:59:05Z, host thirdshift. Uncommitted work at the time of failure is included in this commit.
JacobStephens2
marked this pull request as ready for review
October 7, 2026 12:11
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both review briefs request files-read lists. The review compares each axis's list with changed files, closes gaps once, and names anything still unread. Reviewing Session prompts require those unread files in the pull request body.
Regenerated the Prompts and skills page and Markdown prompts. The instruction covers fresh and Continuation implement sessions, Spec review, and Foreign-commit Repair; Continuation has two rendered variants.
Closes #489
Evidence
Before:
git show issue-486:src/prompt.rs | rg -n 'Name in the pull request body any changed file the review left unread'finds no instruction (exit 1).After: the sentence appears in all five affected Markdown prompt variants; all eight
cargo test --bin thirdshift prompts_pagechecks pass, including both generated-output golden checks.Before: reviewers did not report file coverage or close unread-file gaps.
After: this branch's separate Standards and Spec reviewers each reported reading all nine changed files; neither raised a finding or left an unread file.
All 19
cargo test --test fresh_runtests pass, includinggives_the_agent_the_fresh_prompt.cargo fmt --check,cargo check --all-targets,cargo clippy --all-targets -- -D warnings, andcargo testpass (1,341 passed, 0 failed, 1 ignored).CI is green on
9ab61c8: Linux, macOS, and both release artifact builds.Test seams
prompts/, through their existing golden-file tests.fresh_run::gives_the_agent_the_fresh_prompt.Merge Danger
Door: two-way
Revert the prompt and Factory skill changes and regenerate their outputs.
Blast Radius: review
Changes the review procedure and the instructions carried by reviewing Session prompts.
Unaddressed findings
Standards
None; the reviewer raised no findings.
Spec
None; the reviewer raised no findings.
Unread changed files
Both reviewers read these changed files:
prompts/continuation-pr.mdprompts/continuation.mdprompts/fresh.mdprompts/review-repair.mdprompts/spec-review.mdsite/prompts/index.htmlskills/thirdshift-code-review/SKILL.mdsrc/prompt.rstests/fresh_run.rsReviewed the whole branch against
issue-486, pinned atec45562d3fe802ba3e450226b82a10e53165f475. Generated files were read through changed hunks and relevant surrounding context. Neither axis needed a follow-up.Built with codex · gpt-6.1-sol · xhigh