Skip to content

Reviewers list the files they read #489

Closed

Description

@JacobStephens2

Parent

#486

What to build

Each reviewer says what it read, and the review closes the gaps once:

  • Both briefs ask for a list. Each of the thirdshift-code-review skill's two sub-agent briefs asks the sub-agent to list the files it read.
  • One retry. The skill compares each list with the change's files, and sends any changed file a sub-agent didn't read back to it once. On a Harness where a finished sub-agent can't be asked again, a fresh one reads just those files.
  • The rest is named. The aggregated report names any changed file still unread.
  • The PR body shows it. The shared review instruction tells the author to name, in the pull request body, any changed file the review left unread.

Acceptance criteria

  • Both briefs ask for the list of files read.
  • A changed file missing from a sub-agent's list goes back to it once, and only once. A file still unread after that is reported, not retried.
  • The aggregated report names every changed file still unread, or says none is.
  • The prompts page shows the four prompts asking for unread changed files to be named in the pull request body.

Blocked by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions