Repository navigation
Add a coding standard for deadlines in tests - #1654
Merged
Merged
Conversation
Short deadlines in tests made main's CI red on loaded macOS runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Deadlines in tests section to
CODING_STANDARDS.md. This is option 2 from #1561.Main's CI went red repeatedly on tests that gave the code under test a one-second
--timeoutwhile other work had to finish inside the same deadline. That other work included Trial sessions, code checks, the model Grader, and output the test read afterwards. On a loaded macOS runner it sometimes didn't finish in time (#1458; fixed in #1560). The new section asks tests to:The code review's Standards axis reads
CODING_STANDARDS.md, so it applies this rule to every PR.Evidence
An A/A Experiment on main compared two otherwise identical private suites of code-review Eval tasks. One suite's tasks add this section to the reviewed repository; the other's don't. The tasks are three thirdshift PRs that each added a test with a one-second deadline that later went flaky: #1143, #1145 and #1286. Each task had 6 Trials per condition, run on codex with gpt-6.1-sol at xhigh effort.
Reports with the section cite it, quote the
--timeoutline, and name the work that has to finish under the deadline. One also traced the Bar timeout into the model Grader, which was the cause of #1458's failure.Caveats:
🤖 Generated with Claude Code